Bugfix/increase width of dropdown in runs table filter #4990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karan Gupta <guptakaran725@gmail.com>
…lflow Signed-off-by: Karan Gupta <guptakaran725@gmail.com>
github-actions
bot
added
area/uiux
dbczumar
reviewed
Nov 4, 2021
| @@ -373,7 +373,7 @@ span.error-message { | |||
| } | |||
|
|
|||
| .ExperimentView .sort-select { | |||
| width: 200px; | |||
| width: 300px; | |||
There was a problem hiding this comment.
Is it possible to dynamically size this according to the contents?
There was a problem hiding this comment.
I will take a look if it is possible to dynamically size this.
There was a problem hiding this comment.
@dbczumar Kindly take a look at the latest commits for dynamic width sizing and let me know if this looks good.
Signed-off-by: Karan Gupta <guptakaran725@gmail.com>
27 tasks
|
@coder-freestyle Closing as a duplicate of #5018 now that #5018 has been approved. I'll absolutely make sure you're included in the release note attribution for this feature! Thank you for your contribution! |
|
Thanks for the guidance @dbczumar. Happy to help to the project 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Increase the width of the dropdown so that sort by options do not get truncated in case of long names #4822
How is this patch tested?
Ran the unit tests using pytest
Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes