Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Runs table filter dropdown is narrow, truncates content #4822

Closed
1 of 20 tasks
dbczumar opened this issue Sep 17, 2021 · 16 comments
Closed
1 of 20 tasks

[BUG] Runs table filter dropdown is narrow, truncates content #4822

dbczumar opened this issue Sep 17, 2021 · 16 comments
Assignees
Labels
area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server bug Something isn't working good first issue Good for newcomers help wanted We would like help from the community to add this support

Comments

@dbczumar
Copy link
Collaborator

dbczumar commented Sep 17, 2021

MLflow Roadmap Item

This is an MLflow Roadmap item that has been prioritized by the MLflow maintainers. We're seeking help with the implementation of roadmap items tagged with the help wanted label.

For requirements clarifications and implementation questions, or to request a PR review, please tag @BenWilson2 in your communications related to this issue.

System information

  • Have I written custom code (as opposed to using a stock example script provided in MLflow): No
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): OSX 10.15
  • MLflow installed from (source or binary): Binary
  • MLflow version (run mlflow --version): 1.20.2
  • Python version: 3.8
  • npm version, if running the dev UI: NA
  • Exact command to reproduce: mlflow ui

Describe the problem

In the MLflow experiment UI, the dropdown for sorting columns (i.e. parameters, metrics, and tags) in the Runs table in ascending / descending order is narrow, so column names are cut off.

For example, see:

Screen Shot 2021-09-16 at 8 42 00 PM

This dropdown should be widened.

Code to reproduce issue

  1. Run the following Python code and then launch the MLflow UI by running mlflow ui from the same directory:
import mlflow

for _ in range(10):
    with mlflow.start_run():
        for i in range(10):
            mlflow.log_param("my_medium_param_key_" + str(i), str(i))
  1. Open the column sorting dropdown in the experiment UI

What component(s), interfaces, languages, and integrations does this bug affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations
@dbczumar dbczumar added bug Something isn't working good first issue Good for newcomers labels Sep 17, 2021
@dbczumar dbczumar added this to the MLflow Roadmap milestone Sep 17, 2021
@github-actions github-actions bot added the area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server label Sep 17, 2021
@dbczumar dbczumar added the help wanted We would like help from the community to add this support label Sep 17, 2021
@dbczumar dbczumar assigned dbczumar and unassigned dbczumar Sep 23, 2021
@SadiaAfrinPurba
Copy link

@dbczumar I would like to work on this issue.

@dbczumar
Copy link
Collaborator Author

@SadiaAfrinPurba Sounds great! I’ll assign the issue to you. Please let me know if you have any questions. Thank you in advance for your contribution!

@dbczumar
Copy link
Collaborator Author

dbczumar commented Oct 4, 2021

Hi @SadiaAfrinPurba, were you able to take a look at this issue? Are there any questions I can help answer?

@SadiaAfrinPurba
Copy link

Hi @dbczumar, apologize for the late reply. I missed this notification. I've looked into this issue and for now, I do not have any questions. I am familiarizing myself with the codebase and hopefully, I will give any updates by next week.

@NieuweNils
Copy link
Contributor

NieuweNils commented Oct 30, 2021

@dbczumar , @SadiaAfrinPurba Is this issue still open? I'm new to the project and would love to help out and contribute.

@dbczumar
Copy link
Collaborator Author

Hi @NieuweNils . Yes, the issue is still open and we would definitely welcome your contribution! Thank you in advance and let me know if you have any questions!

@NieuweNils
Copy link
Contributor

Great to hear I can help! Will definitely let you know if I need anything.

@DrPuneetGaur
Copy link

@NieuweNils Please let me know if you have got an opportunity to work on this issue. If not, I will raise a PR as I have figured out the fix for this issue.

@dbczumar
Copy link
Collaborator Author

dbczumar commented Nov 4, 2021

Hi @NieuweNils . Please let me know if you have updates here. @coder-freestyle I've left a comment on the linked PR here: https://github.com/mlflow/mlflow/pull/4990/files#r742467554

@DrPuneetGaur
Copy link

@dbczumar Kindly take a look at the latest commits for dynamic width sizing and let me know if this looks good.

@NieuweNils
Copy link
Contributor

NieuweNils commented Nov 7, 2021

Hi @dbczumar , @coder-freestyle!
I Was busy with work, sorry for the late reply!

I was trying to find out how to do a dynamic resize from the get-go but did not yet see how to get it done.
Setting the width to "auto" in css doesn't do the trick for me.
If I'm not mistaken, a "Select" field should automatically resize with the biggest "Option" it contains, but it doesn't do that for some reason.
Trying to find out how set it to do that on focus (when you expand the drop down).

I'm not a front-ender by trade, so if anyone has a suggestion (@coder-freestyle, maybe?), feel free to help :)

@cedkoffeto
Copy link
Contributor

Hi @NieuweNils

Just an idea
Maybe you can add a tooltip that will contain the full name of the metric.

Thanks.

@NieuweNils
Copy link
Contributor

NieuweNils commented Nov 7, 2021

@dbczumar
I opened a PR!
The fix automatically changes column width for the selected column, and has a bigger drop down (20% of screen size).

@NieuweNils
Copy link
Contributor

NieuweNils commented Nov 7, 2021

@cedkoffeto The issue says the drop down should be widened, so I stuck to that. Thanks for your suggestion though!

@dbczumar
Copy link
Collaborator Author

dbczumar commented Nov 8, 2021

Closing this now that #5018 is merged. Thanks @NieuweNils @coder-freestyle !

@dbczumar dbczumar closed this as completed Nov 8, 2021
@DrPuneetGaur
Copy link

@dbczumar I was looking at an alternate solution for this issue for future references which would truncate the extra white space introduced due to min-width being set as 30%. We can set the dropdownMatchSelectWidth as false and keep the width in CSS as auto. Attaching the code snippet and the user interface screenshot.

Screenshot 2021-11-09 at 3 37 00 PM

Screenshot 2021-11-09 at 3 37 26 PM

Please let me know your thoughts (in case a PR needs to be raised)

FYI @NieuweNils

@BenWilson2 BenWilson2 removed this from the MLflow Roadmap milestone Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/uiux Front-end, user experience, plotting, JavaScript, JavaScript dev server bug Something isn't working good first issue Good for newcomers help wanted We would like help from the community to add this support
Projects
None yet
Development

No branches or pull requests

6 participants