New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional 'drafts' level to inclusion #3476
Conversation
9493d55
to
78a2c81
Compare
Thanks! I wanted to do just this, again thanks for pushing this. |
Sure, pick away. I know it's a breaking change, but it shouldn't be too bad for users. I think the addition of a "drafts" level makes it easier to understand the intention and behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I'll probably move forward with this.
78a2c81
to
006cf17
Compare
006cf17
to
1763292
Compare
Another option might be to deprecate the 'exclude_docs' setting and rename what 'exclude_docs' is doing in this PR to 'ignore'? That way folks using 'exclude_docs' will get a warning. |
@athackst |
1763292
to
1366d1c
Compare
@oprypin I think the The issue is that there isn't an additional way to ignore files in the
|
1366d1c
to
0309783
Compare
Let me know if you have any more nit picks! I could "move" the |
Here are my current thoughts: I had a quick look around in search, and it appears that almost every use of With that in mind, I think the cumulative annoyance of renaming this option will be greater than the rare annoyance that the feature suddenly stopped doing drafts. With that, I propose to move back to the plan of not deprecating the name Then, what to do about drafts... Actually I was hoping to remove it entirely and instead immediately provide a plugin to do the same feature. But actually for a plugin, to provide all the same functionality of still validating links, its source code would have to be 5x clunkier, if at all possible. There also would be the matter of having two breakages for this feature - first renaming it, then dropping it. So perhaps keep this feature permanently? Maybe name it |
So I force-pushed the exact old version of your commit into this branch instead. |
(And could we just use |
I have pushed changes for final touches per my preference. |
Thanks for the discussion, it's been a pleasure. I'll update my other PR after this one merges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you as well, and thanks for the patience
This change adds a "drafts" configuration option so that files can be appropriately marked as 'draft' to be included in the local server, and files that shouldn't be included at all are marked in 'exclude_docs'.
This change helps #3450 by allowing users to fully exclude paths.