New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support docs from the root directory. #3450
base: master
Are you sure you want to change the base?
Conversation
It might be worth considering an "ignore" option for |
fb5cd7d
to
42ff3a1
Compare
Thanks for pushing this forward. Sadly, I think this is too many steps that users would have to take in order to use this. If someone runs into this unprepared, confusion is fully guaranteed. |
To be clear, it's still usable as is. A normal user would not even notice the extra site folder since nothing links to it. It just copies more than it needs to into the temp directory that serves the site. It performs as expected on a normal build. |
0389e27
to
68ad2a3
Compare
68ad2a3
to
d153d4a
Compare
Note that advertising that |
I wouldn't advocate for changing the default from the 'docs' directory. I think there are legitimate use cases for wanting to call mkdocs from root though. It's a feature that's been requested a fair amount through mkdocs history. |
My last conclusion on this was that the feature request is good but the exact change I wanted to be done differently. So, I was using this PR as if it's an issue and the actual pull request I wanted to merge is #3519. To avoid confusion, maybe this pull request should be closed and an issue opened instead. |
Per discussion #3062 this change would allow users to build a mkdocs site from the root directory.
This change removes the validation checks for the site directory to not be within the docs directory.
If the site folder is within the docs directory, it will mark them as 'EXCLUDED'
Tested: