Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controlpickermenu: add missing controls, remove 'key' reset menus #3093

Merged
merged 1 commit into from
Sep 14, 2020
Merged

controlpickermenu: add missing controls, remove 'key' reset menus #3093

merged 1 commit into from
Sep 14, 2020

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Sep 12, 2020

@ronso0 ronso0 added this to In progress in 2.3 release via automation Sep 12, 2020
@ronso0 ronso0 added this to the 2.3.0 milestone Sep 12, 2020
@ronso0 ronso0 changed the title controlpickermenu: add 'pitch_up/down..' controls, remove 'key' reset menus [WIP] controlpickermenu: add missing controls, remove 'key' reset menus Sep 13, 2020
2.3 release automation moved this from In progress to In Review Sep 14, 2020
daschuer
daschuer approved these changes Sep 14, 2020
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for taking care.

@daschuer daschuer merged commit a7cd202 into mixxxdj:2.3 Sep 14, 2020
2.3 release automation moved this from In Review to Done Sep 14, 2020
@ronso0 ronso0 deleted the controllerpicker-additions branch September 14, 2020 16:50
@ronso0
Copy link
Member Author

ronso0 commented Sep 14, 2020

actually this was a only a day old and WIP as I just asked the reporter to post more un-mappable controls here, like some skin controls.
will open a new PR

@Holzhaus
Copy link
Member

I suggest to use a draft PR, that makes it more unlikely to merge by accident.

@mxmilkiib
Copy link
Contributor

Had another go at clicking-everything whilst the MIDI learn is on, turned up these;
[EffectRack1_EffectUnit1_Effect1],button_parameter3
[EffectRack1_EffectUnit1_Effect2],button_parameter1
[EffectRack1_EffectUnit1_Effect3],button_parameter1
[EffectRack1_EffectUnit2_Effect3],button_parameter2
etc.

@ronso0
Copy link
Member Author

ronso0 commented Sep 17, 2020 •
edited

interesting, I thought fx parameters were covered by https://github.com/mixxxdj/mixxx/blob/2.3/src/controllers/controlpickermenu.cpp#L638 but appearanly it's just about the knobs.
side note: for fx it's recommended to use the components fx mapping.

Let's collect more controls here and start another PR soonish

@ronso0 ronso0 mentioned this pull request Sep 22, 2020
Merged
5 tasks
@ronso0
Copy link
Member Author

ronso0 commented Sep 22, 2020

@mxmilkiib I just started #3112
If you come across other missing controls please post them there. Thanks!

@ronso0 ronso0 changed the title [WIP] controlpickermenu: add missing controls, remove 'key' reset menus controlpickermenu: add missing controls, remove 'key' reset menus Oct 27, 2020
@mixxxbot mixxxbot mentioned this pull request Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
controller mappings ui
Projects
No open projects
2.3 release
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ronso0 @Holzhaus @mxmilkiib @daschuer