Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot MIDI learn key pitch up/down #10104

Closed
mixxxbot opened this issue Aug 23, 2022 · 8 comments
Closed

Cannot MIDI learn key pitch up/down #10104

mixxxbot opened this issue Aug 23, 2022 · 8 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: mxmilkiib
Date: 2020-09-12T02:58:40Z
Status: Fix Released
Importance: Medium
Launchpad Issue: lp1895364
Tags: controllers, gui


"The control you clicked in Mixxx is not learnable.
This could be because you are using an old skin and this control is no longer supported.

You tried to learn: [Channel1],pitch_down/
You tried to learn: [Channel1],pitch_up/
etc. on other channels

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-12T21:22:50Z


Those controls are missing from https://github.com/mixxxdj/mixxx/blob/2.3/src/controllers/controlpickermenu.cpp

I'm about to add those.
Did you find other controls that are not learnable?

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-12T22:04:36Z


#3093

@mixxxbot
Copy link
Collaborator Author

Commented by: mxmilkiib
Date: 2020-09-12T22:06:08Z


You tried to learn: [Shoutcast],enabled
You tried to learn: [Master],skin_settings
You tried to learn: [Deere],bpm_layout_next
You tried to learn: [Deere],key_layout_next
You tried to learn: [EffectRack1_EffectUnit1],mix_mode
You tried to learn: [Library],show_library
You tried to learn: [Auxiliary1],VuMeter

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-13T17:52:57Z


okay, let's please focus on controls that have actual value for controllers.
It's pointless to map inputs to visuals like Vu meters or GUI toggles (for example to toggle the skin menu and BPM/key sections) as users would have to use the mouse for those sections anyway.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-13T17:54:45Z


We may add GUI controls like [Library],show_library (only used in Deere) or [Master],show_mixer though.

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-13T17:55:18Z


Please report additional controls in #3093

@mixxxbot
Copy link
Collaborator Author

Commented by: ronso0
Date: 2020-09-23T18:04:25Z


follow-up is #3112

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant