fix(sw, notification): Don't issue an event if there is no affect #8979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
affectedってTypeORM+PostgreSQLの組み合わせだと機能しなかった気がしたけど直ったのかな |
|
なんか動いてる感じがある |
|
結局直ってるのかどうかよくわからない感じだった 動いてる感じあるなら大丈夫そう |
|
そもそもだけど readNotifications をSWに送らないでも良さそう |
|
読んだことにする判定が広すぎて読んだことにされても読んでない通知が消えちゃうのは微妙なことがあるというのはある
仕様なの？？？ |
良くないです (好みの問題ではありそう)
i/notifications叩いただけでread扱いになる仕様は微妙かも
実装当初はaffectedが仕事しなかったのでとりあえずこの仕様になった。サードパーティアプリを考えなければ不具合を引き起きすようなものではないし、私の脳内ではバグという認識だった |
|
meiv23では消えてた |
|
🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8906 (comment)
What
updateの結果のうちaffectedが0である場合、readNotificationsまたはreadAllNotificationsイベントは発行されないように
Why
#8906 (comment) はバグではなく仕様ではあるが、イベントを毎度送る必要もなさそうなので、affectedが0の場合はイベントを発行しない。