Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Push notifications have been updated" message pops up every time Misskey is opened #8824

Closed
normikoto opened this issue Jun 12, 2022 · 16 comments
Labels
⚠️bug? This might be a bug packages/sw and PWA ServiceWorker and PWA related issue/PR

Comments

@normikoto
Copy link
Contributor

normikoto commented Jun 12, 2022

💡 Summary

Whenever I open Misskey with notifications enabled, I get a "Push notifications have been updated" message every time.
This message seems to also pop up when I access Misskey from a different browser at the same time.

🥰 Expected Behavior

No notifications should show up unless there are unread ones.

🤬 Actual Behavior

A "Push notifications have been updated" notification appears when logging in.
No message appears in the browser Javascript console for me.

📝 Steps to Reproduce

  1. Log into Misskey (or just open a new session if already logged in)
  2. Notification "Push notifications have been updated" appears
  3. (optional) Open Misskey in another browser, message will appear again

📌 Environment

Misskey version: 12.111.1
Your OS: Linux (Fedora 36)
Your browser: Google Chrome 102.0.5005.115 and Firefox 101.0

@normikoto normikoto added the ⚠️bug? This might be a bug label Jun 12, 2022
@Johann150
Copy link
Contributor

not sure if this is related to #8819

@normikoto
Copy link
Contributor Author

Yeah that got merged into 12.111.1 but I still get this

@mi-24v
Copy link

mi-24v commented Jun 13, 2022

see #8816
this might be cause high pressure at backend

@tamaina
Copy link
Member

tamaina commented Jun 13, 2022

please translate

このメッセージはuser_visible_auto_notificationの出現を防止するためのメッセージです。
このメッセージがサーバーに負荷をかけることはありません。

readについてのプッシュメッセージを受けて通知を取り下げた時にuser_visible_auto_notificationが出現するのを防ぐ為にあえてプッシュ通知を短い期間表示しています。

@tamaina
Copy link
Member

tamaina commented Jun 13, 2022

より詳しく言うと、このメッセージはreadNotificationsやreadAllNotificationsなどが発行されるたびに表示されます。

Misskeyを開いたときに通知リストを表示するような画面構成になっている場合、i/notificationsの結果としてreadNotificationsかreadAllNotificationsが発行されます。

これがMisskeyを開くとそのメッセージが表示される原理です。

@tamaina
Copy link
Member

tamaina commented Jun 13, 2022

これが不快な実装であることは私も共感しますが、user_visible_auto_notificationにまつわる制約がある限りはこの実装が最善であると思っています。

もしくは既読で通知を取り下げるのを諦めるかです。

@tamaina
Copy link
Member

tamaina commented Jun 13, 2022

(ところで、なんとなく通知のcloseって機能してない気がするんだけど)

@nvisser

This comment was marked as off-topic.

@tamaina

This comment was marked as off-topic.

@tamaina
Copy link
Member

tamaina commented Jun 14, 2022

(ところで、なんとなく通知のcloseって機能してない気がするんだけど)

いや、ちゃんと動いている

@tamaina

This comment was marked as off-topic.

@tamaina

This comment was marked as off-topic.

@rinsuki
Copy link
Contributor

rinsuki commented Jun 14, 2022

もしくは既読で通知を取り下げるのを諦めるかです。

プッシュ通知なんかサーバー側の既読状態と同期されないがちなことが多い気がするしこのオプションあってもいいかもしれない

@tamaina
Copy link
Member

tamaina commented Jun 14, 2022

SubwayTooterの問題は #8835

@memo-567
Copy link

This pop up message will appear instead of the post, as it was done in the previous version, except direct messages.

DM works in notifications as usual.

@tamaina
Copy link
Member

tamaina commented Nov 18, 2022

#8979 で直ったと思うのでclose(直ってなかったらreopenしてください)

@tamaina tamaina closed this as completed Nov 18, 2022
@tamaina tamaina added the packages/sw and PWA ServiceWorker and PWA related issue/PR label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug packages/sw and PWA ServiceWorker and PWA related issue/PR
Projects
None yet
Development

No branches or pull requests

7 participants