Use 1s timeout for fetching imdsv2 token #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
approved these changes
Mar 2, 2022
|
@harshavardhana Any chance that we can get a release that includes this change? The 120s delay is very painful! |
justfalter
added a commit
to justfalter/bazel-remote
that referenced
this pull request
Mar 11, 2022
- Update minio-go so that we can get a fix for timeouts encountered when trying to retrieve IMDSv2 tokens during IAM s3 authentication. When bazel-remote is run within a container on an aws ec2 instance, initial attempts to authenticate using IAM will encounter a 120s delay. The issue is the result of changes in the ec2 metadata services with IMDSv2, which restricts how many network hops may be incurred before for PUT statements. When executing directly on the ec2 instance, it is 1 hop away, and is allowed. When executing within a docker container on an ec2 instance, it is 2 hops away, and is forbidden. The change to minio go reduces the timeout from 120s to 1s. Apparently this token request is optional, so things continue to work afterward, regardless. minio/minio-go#1626
mostynb
pushed a commit
to buchgr/bazel-remote
that referenced
this pull request
Mar 11, 2022
- Update minio-go so that we can get a fix for timeouts encountered when trying to retrieve IMDSv2 tokens during IAM s3 authentication. When bazel-remote is run within a container on an aws ec2 instance, initial attempts to authenticate using IAM will encounter a 120s delay. The issue is the result of changes in the ec2 metadata services with IMDSv2, which restricts how many network hops may be incurred before for PUT statements. When executing directly on the ec2 instance, it is 1 hop away, and is allowed. When executing within a docker container on an ec2 instance, it is 2 hops away, and is forbidden. The change to minio go reduces the timeout from 120s to 1s. Apparently this token request is optional, so things continue to work afterward, regardless. minio/minio-go#1626
This was referenced Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1489 introduced IMDSv2 support. Similar to the issues described in the official AWS SDK (aws/aws-sdk-go#2972), the IAM credential provider potentially introduces a several minute delay.
The AWS SDK solved this by setting a 1s timeout for the metadata service request. This PR adds the same timeout.
Closes #1625