Skip to content

Commit

Permalink
Update minio-go - fix for s3 IAM auth delays
Browse files Browse the repository at this point in the history
- Update minio-go so that we can get a fix for timeouts encountered when
  trying to retrieve IMDSv2 tokens during IAM s3 authentication. When
  bazel-remote is run within a container on an aws ec2 instance, initial
  attempts to authenticate using IAM will encounter a 120s delay. The
  issue is the result of changes in the ec2 metadata services with
  IMDSv2, which restricts how many network hops may be incurred before
  for PUT statements. When executing directly on the ec2 instance, it
  is 1 hop away, and is allowed. When executing within a docker
  container on an ec2 instance, it is 2 hops away, and is forbidden. The
  change to minio go reduces the timeout from 120s to 1s. Apparently
  this token request is optional, so things continue to work afterward,
  regardless.
  minio/minio-go#1626
  • Loading branch information
justfalter authored and mostynb committed Mar 11, 2022
1 parent 8a93ff7 commit 11896b9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion go.mod
Expand Up @@ -10,7 +10,7 @@ require (
github.com/google/uuid v1.3.0
github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0
github.com/klauspost/compress v1.14.1
github.com/minio/minio-go/v7 v7.0.20
github.com/minio/minio-go/v7 v7.0.24-0.20220302185830-f2d40be3e82f
github.com/mostynb/go-grpc-compression v1.1.16
github.com/mostynb/zstdpool-syncpool v0.0.12
github.com/prometheus/client_golang v1.11.0
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Expand Up @@ -265,6 +265,8 @@ github.com/minio/md5-simd v1.1.2 h1:Gdi1DZK69+ZVMoNHRXJyNcxrMA4dSxoYHZSQbirFg34=
github.com/minio/md5-simd v1.1.2/go.mod h1:MzdKDxYpY2BT9XQFocsiZf/NKVtR7nkE4RoEpN+20RM=
github.com/minio/minio-go/v7 v7.0.20 h1:0+Xt1SkCKDgcx5cmo3UxXcJ37u5Gy+/2i/+eQYqmYJw=
github.com/minio/minio-go/v7 v7.0.20/go.mod h1:ei5JjmxwHaMrgsMrn4U/+Nmg+d8MKS1U2DAn1ou4+Do=
github.com/minio/minio-go/v7 v7.0.24-0.20220302185830-f2d40be3e82f h1:5+NaPkyAjRvzl81ZN3N7VgMYsQwbYwnj3NQ2CJpxwX0=
github.com/minio/minio-go/v7 v7.0.24-0.20220302185830-f2d40be3e82f/go.mod h1:ei5JjmxwHaMrgsMrn4U/+Nmg+d8MKS1U2DAn1ou4+Do=
github.com/minio/sha256-simd v0.1.1/go.mod h1:B5e1o+1/KgNmWrSQK08Y6Z1Vb5pwIktudl0J58iy0KM=
github.com/minio/sha256-simd v1.0.0 h1:v1ta+49hkWZyvaKwrQB8elexRqm6Y0aMLjCNsrYxo6g=
github.com/minio/sha256-simd v1.0.0/go.mod h1:OuYzVNI5vcoYIAmbIvHPl3N3jUzVedXbKy5RFepssQM=
Expand Down

0 comments on commit 11896b9

Please sign in to comment.