Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

Bumped y18n package version to 5.0.5 #104

Closed
wants to merge 5 commits into from
Closed

Bumped y18n package version to 5.0.5 #104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bbbc5bd
bumped y18n version to 5.0.5
Dec 1, 2020
48371fb
Merge branch 'main' into bugfix/update-y18n-package-version
maleekha Dec 4, 2020
8069153
uninstalling y18n as a direct package from package.json
maleekha Dec 4, 2020
d6bd4f4
Updated package-lock.json : manually upgraded the version for y18n pa…
maleekha Dec 4, 2020
04370aa
Update package-lock.json
maleekha Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 17 additions & 4 deletions client/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion client/package.json
View file
Open in desktop
Expand Up @@ -26,7 +26,8 @@
"react-router-dom": "^5.1.2",
"react-virtualized-auto-sizer": "^1.0.2",
"react-window": "^1.8.5",
"uuid": "^8.0.0"
"uuid": "^8.0.0",
"y18n": "^5.0.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding this dependency directly inside package.json? y18n should be coming to us via some transitive relationship. IMHO, let's try to understand what that relation is and then try fixing the dependency that we actually depend on, instead of having adding a dependency on a new component.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on installing the latest version of the y18n package, this dependency got added directly in package.json
sure, I'll see what the relation is for y18n

},
"devDependencies": {
"@testing-library/jest-dom": "^4.2.4",
Expand Down