This repository has been archived by the owner on May 16, 2023. It is now read-only.
Bumped y18n package version to 5.0.5 #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adbindal
suggested changes
Dec 3, 2020
client/package.json
Outdated
| @@ -26,7 +26,8 @@ | |||
| "react-router-dom": "^5.1.2", | |||
| "react-virtualized-auto-sizer": "^1.0.2", | |||
| "react-window": "^1.8.5", | |||
| "uuid": "^8.0.0" | |||
| "uuid": "^8.0.0", | |||
| "y18n": "^5.0.5" | |||
There was a problem hiding this comment.
Why are we adding this dependency directly inside package.json? y18n should be coming to us via some transitive relationship. IMHO, let's try to understand what that relation is and then try fixing the dependency that we actually depend on, instead of having adding a dependency on a new component.
There was a problem hiding this comment.
on installing the latest version of the y18n package, this dependency got added directly in package.json
sure, I'll see what the relation is for y18n
adbindal
approved these changes
Jan 7, 2021
|
This is a transitive dependency and shouldn't be updated like this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for reference-
issue: yargs/y18n#96
fix: yargs/y18n#108