Crash the process on unexpected failures when creating a JoinableTask
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strictly speaking this is not necessary, as an exception would be thrown to the caller and no lingering adverse effects to the state of `JoinableTaskContext` are left behind. But we find this change useful because this is scheduling code and should be very reliable. Recently an `OutOfMemoryException` was thrown from this code (in a process with plenty of memory) and led other code to hang because it didn't expect JTF itself to fail. See microsoft#843 for more info on that.
AArnott
requested review from
ryanmolden,
CyrusNajmabadi,
jdrobison,
lifengl and
JoshuaBStevens
CyrusNajmabadi
approved these changes
May 5, 2021
ryanmolden
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strictly speaking this is not necessary, as an exception would be thrown to the caller and no lingering adverse effects to the state of
JoinableTaskContextare left behind. But we find this change useful because this is scheduling code and should be very reliable. Recently anOutOfMemoryExceptionwas thrown from this code (in a process with plenty of memory) and led other code to hang because it didn't expect JTF itself to fail. See #843 for more info on that.Validation
I tested this crashes the process with the faulting callstack intact (i.e. not unwound) by manually adding a
throw new OutOfMemoryException();near where we allocate aWeakReference<T>.Automated tests aren't effective here because the if exercised, the new code would crash the test runner. And anyway forcing the error condition is impossible given no extensibility point exists for this area.