Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash the process on unexpected failures when creating a JoinableTask #846

Merged
merged 1 commit into from May 5, 2021
Merged

Crash the process on unexpected failures when creating a JoinableTask #846

merged 1 commit into from May 5, 2021

Commits on May 5, 2021

  1. Crash the process on unexpected failures when creating a JoinableTask 

    Strictly speaking this is not necessary, as an exception would be thrown to the caller and no lingering adverse effects to the state of `JoinableTaskContext` are left behind. But we find this change useful because this is scheduling code and should be very reliable. Recently an `OutOfMemoryException` was thrown from this code (in a process with plenty of memory) and led other code to hang because it didn't expect JTF itself to fail. See microsoft#843 for more info on that.
    @AArnott
    AArnott committed May 5, 2021
    Copy the full SHA
    6777035 View commit details
    Browse the repository at this point in the history