Merge pull request #846 from AArnott/crashOnJtfFailure

Crash the process on unexpected failures when creating a `JoinableTask`
microsoft · May 5, 2021 · 63476ca · 63476ca
2 parents 1cf326e + 6777035
commit 63476ca
Showing 1 changed file with 27 additions and 11 deletions.
diff --git a/src/Microsoft.VisualStudio.Threading/JoinableTaskFactory.cs b/src/Microsoft.VisualStudio.Threading/JoinableTaskFactory.cs
@@ -686,21 +686,37 @@ private JoinableTask<T> RunAsync<T>(Func<Task<T>> asyncMethod, bool synchronousl
 
         private void ExecuteJob<T>(Func<Task> asyncMethod, JoinableTask job)
         {
-            using (var framework = new RunFramework(this, job))
+            try
             {
-                Task asyncMethodResult;
-                try
+                using (var framework = new RunFramework(this, job))
                 {
-                    asyncMethodResult = asyncMethod();
-                }
-                catch (Exception ex)
-                {
-                    var tcs = new TaskCompletionSource<T>();
-                    tcs.SetException(ex);
-                    asyncMethodResult = tcs.Task;
+                    Task asyncMethodResult;
+                    try
+                    {
+                        asyncMethodResult = asyncMethod();
+                    }
+                    catch (Exception ex)
+                    {
+                        var tcs = new TaskCompletionSource<T>();
+                        tcs.SetException(ex);
+                        asyncMethodResult = tcs.Task;
+                    }
+
+                    job.SetWrappedTask(asyncMethodResult);
                 }
+            }
+            catch (Exception ex) when (FailFast(ex))
+            {
+                // We use a crashing exception filter to capture all the detail possible (even before unwinding the callstack)
+                // when an exception is thrown from this critical method.
+                // In particular, we have seen the WeakReference object that is instantiated by "new RunFramework" throw OutOfMemoryException.
+                throw Assumes.NotReachable();
+            }
 
-                job.SetWrappedTask(asyncMethodResult);
+            static bool FailFast(Exception ex)
+            {
+                Environment.FailFast("Unexpected exception thrown in critical scheduling code.", ex);
+                throw Assumes.NotReachable();
             }
         }