Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SpaceNet3 #480

Merged
merged 5 commits into from Mar 29, 2022
Merged

Add SpaceNet3 #480

merged 5 commits into from Mar 29, 2022

Conversation

ashnair1
Copy link
Collaborator

  • Added SpaceNet3
  • Refactored SpaceNet5 to inherit from SpaceNet3
  • Added tests and test data for SpaceNet3

@github-actions github-actions bot added datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing labels Mar 24, 2022
@ashnair1 ashnair1 mentioned this pull request Mar 24, 2022
Closed
7 tasks
@adamjstewart adamjstewart added this to the 0.3.0 milestone Mar 24, 2022
adamjstewart
adamjstewart reviewed Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these requests are optional, but here are things I've seen that could be changed or are starting to diverge from what we do in other datasets.

tests/datasets/test_spacenet.py Show resolved Hide resolved
tests/datasets/test_spacenet.py Outdated Show resolved Hide resolved
torchgeo/datasets/spacenet.py Show resolved Hide resolved
torchgeo/datasets/spacenet.py Outdated Show resolved Hide resolved
@ashnair1
Copy link
Collaborator Author

Docs are failing due to to the new Jinja release. Refer jupyter/nbconvert#1736. Should be solved once jupyter/nbconvert#1737 is merged.

adamjstewart
adamjstewart reviewed Mar 25, 2022
View reviewed changes
tests/datasets/test_spacenet.py Outdated Show resolved Hide resolved
tests/datasets/test_spacenet.py Outdated Show resolved Hide resolved
torchgeo/datasets/spacenet.py Outdated Show resolved Hide resolved
torchgeo/datasets/spacenet.py Show resolved Hide resolved
adamjstewart
adamjstewart approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give others a few days to review before merging. Looking forward to SpaceNet6!

@adamjstewart
Copy link
Collaborator

I believe the jinja bug is fixed, closing and reopening to restart the tests.

@adamjstewart adamjstewart reopened this Mar 26, 2022
@adamjstewart adamjstewart enabled auto-merge (squash) March 26, 2022 16:22
@adamjstewart
Copy link
Collaborator

Ah, jinja2 was fixed, but not nbconvert

calebrob6
calebrob6 reviewed Mar 26, 2022
View reviewed changes
torchgeo/datasets/spacenet.py
root, image, collections, transforms, download, api_key, checksum
)

def _load_mask(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth doing all the rasterization up front in the download/setup?

@calebrob6
Copy link
Member

Looks good to me! @ashnair1, I'm curious whether you have used these datasets for training models?

@ashnair1
Copy link
Collaborator Author

Looks good to me! @ashnair1, I'm curious whether you have used these datasets for training models?

@calebrob6 I have created models using SpaceNet2. I've written up a datamodule for it but I am planning to make a general SpaceNet datamodule like what we did for the SpaceNet datasets. Haven't gotten around to it yet.

@adamjstewart adamjstewart mentioned this pull request Mar 27, 2022
Merged
auto-merge was automatically disabled March 29, 2022 14:34

Pull request was closed

@adamjstewart adamjstewart reopened this Mar 29, 2022
@adamjstewart adamjstewart enabled auto-merge (squash) March 29, 2022 14:34
@adamjstewart adamjstewart merged commit 2e5c2b2 into microsoft:main Mar 29, 2022
@ashnair1 ashnair1 deleted the spacenet3 branch March 29, 2022 15:28
remtav pushed a commit to remtav/torchgeo that referenced this pull request May 26, 2022
@ashnair1 @remtav
Add SpaceNet3 (microsoft#480)
9039aa8 
* Add SpaceNet3

* Fixes

* Replace itertools.product with zip

* Update docstring

* Remove unused options
@adamjstewart adamjstewart mentioned this pull request Jul 11, 2022
Merged
yichiac pushed a commit to yichiac/torchgeo that referenced this pull request Apr 29, 2023
@ashnair1
Add SpaceNet3 (microsoft#480)
5d1eeeb 
* Add SpaceNet3

* Fixes

* Replace itertools.product with zip

* Update docstring

* Remove unused options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebrob6 calebrob6 calebrob6 left review comments

@adamjstewart adamjstewart adamjstewart approved these changes

Assignees
No one assigned
Labels
datasets Geospatial or benchmark datasets documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashnair1 @adamjstewart @calebrob6