Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpaceNet datasets #159

Closed
7 tasks done
ashnair1 opened this issue Sep 22, 2021 · 6 comments · Fixed by #878
Closed
7 tasks done

SpaceNet datasets #159

ashnair1 opened this issue Sep 22, 2021 · 6 comments · Fixed by #878
Labels
datasets Geospatial or benchmark datasets

Comments

@ashnair1
Copy link
Collaborator

ashnair1 commented Sep 22, 2021

The SpaceNet Dataset contains ~67,000 square km of very high-resolution imagery, >11M building footprints, and ~20,000 km of road labels spread over 7 datasets:

spacenet

This issue is to track the addition of these datasets.

@ashnair1 ashnair1 mentioned this issue Sep 22, 2021
@adamjstewart adamjstewart added the datasets Geospatial or benchmark datasets label Sep 22, 2021
@adamjstewart adamjstewart added this to To do in VisionDataset via automation Sep 22, 2021
@adamjstewart
Copy link
Collaborator

Our conda-forge repo just caught the fact that the SpaceNet datasets import the affine library but we're missing a dependency on affine in setup.cfg. Is affine actually needed? If so, can you determine the minimum supported version and add it to setup.cfg?

@ashnair1
Copy link
Collaborator Author

ashnair1 commented Dec 20, 2021

I believe I only explicitly imported affine for type annotations (in load_image and load_mask). The image transform of a rasterio image object is an Affine object.

Even if it was required, affine is a direct dependency of rasterio (for the above reason). I thought setup.cfg only includes direct dependencies of torchgeo and not its transitive dependencies.

Alternatively I could just replace Affine with Any from the typing module.

@isaaccorley
Copy link
Collaborator

This is a bit of a hack but could we just use 'from rasterio.transform import Affine' instead of 'from affine import Affine'?

@adamjstewart
Copy link
Collaborator

I thought setup.cfg only includes direct dependencies of torchgeo and not its transitive dependencies.

Correct, but if you directly import affine, that makes it a direct dependency.

I actually like @isaaccorley's suggestion, let's do that as long as it passes mypy.

@adamjstewart
Copy link
Collaborator

@ashnair1 where are we at with SpaceNet 6? Would love to be able to close this issue.

@ashnair1
Copy link
Collaborator Author

SpaceNet 6 is currently unavailable on Radiant MLHub. I had raised radiantearth/radiant-mlhub#93 to track this among other issues with the SpaceNet datasets. Will give them a ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets Geospatial or benchmark datasets
Projects
No open projects
VisionDataset
  
To do
Development

Successfully merging a pull request may close this issue.

3 participants