Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apple): embed app manifest directly in code #1985

Merged
merged 1 commit into from Apr 29, 2024
Merged

fix(apple): embed app manifest directly in code #1985

merged 1 commit into from Apr 29, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Apr 23, 2024

Description

Embed app manifest directly in code

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

Test iOS, macOS, visionOS (just swap out ios below):

cd example
pod install --project-directory=ios
yarn ios

# In a separate terminal
yarn start

@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels Apr 23, 2024
@tido64 tido64 mentioned this pull request Apr 23, 2024
Closed
4 tasks
Base automatically changed from tido/remove-nlohmann-json to trunk April 24, 2024 22:54
@tido64 tido64 marked this pull request as ready for review April 25, 2024 06:09
kelset
kelset approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested everything, works as expected 👍

Screenshot 2024-04-29 at 11 50 56

@tido64 tido64 merged commit e975f97 into trunk Apr 29, 2024
30 checks passed
@tido64 tido64 deleted the tido/embed-manifest-swift branch April 29, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelset kelset kelset approved these changes

@Saadnajmi Saadnajmi Awaiting requested review from Saadnajmi Saadnajmi is a code owner

Assignees
No one assigned
Labels
platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS platform: Windows This affects Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tido64 @kelset