Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate code from app.json and avoid parsing JSON at runtime #1722

Closed
4 tasks done
tido64 opened this issue Dec 6, 2023 · 3 comments
Closed
4 tasks done

Generate code from app.json and avoid parsing JSON at runtime #1722

tido64 opened this issue Dec 6, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@tido64
Copy link
Member

tido64 commented Dec 6, 2023

Proposal

We currently parse app.json at runtime. However, app.json does not change at runtime, so it doesn't really make sense that we have to parse it at runtime either. Additionally:

  • On some platforms, this requires additional dependencies (Moshi + KSP on Android, JSON for Modern C++ on Windows) that we have to keep up to date.
  • On Android, there is additional maintenance overhead because KSP is tied to specific versions of Kotlin. In order to allow users to specify their own Kotlin version, we need to keep a list of supported KSP versions.

If we can generate code from app.json that we can embed directly in the app, we can eliminate the need for a JSON parser altogether.

Alternatives

n/a

Implementation Details

Additional Context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@tido64 tido64 added the enhancement New feature or request label Dec 6, 2023
@saram-aman
Copy link

Is it still open?

@tido64
Copy link
Member Author

tido64 commented Mar 15, 2024

Is it still open?

Yes

@tido64
Copy link
Member Author

tido64 commented Apr 29, 2024

All shipped as of 3.5.15

@tido64 tido64 closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants