[iOS][Cocoapods] Make RNM work with use_frameworks #1967

cipolleschi · 2023-11-02T19:29:11Z

Please select one of the following

I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
I am making a fix / change for the macOS implementation of react-native
I am making a change required for Microsoft usage of react-native

Summary:

This change makes react-native-mac build with both the new and the old architecture using use_frameworks! and static linking.

Changelog:

[iOS][Added] - Support for use_frameworks! in both architecture with static linking

Test Plan:

Tested locally with RNTester

cipolleschi · 2023-11-03T13:45:45Z

@microsoft-github-policy-service agree [company="Meta"]

cipolleschi · 2023-11-03T13:46:11Z

@microsoft-github-policy-service agree company="Meta"

Summary: In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that automate adding a dependency to a podspec and it generates the required search paths. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51027343

Summary: React-Core does not depends on any bit of ReactCommon, React-RCTFabric or React-NativeModuleApple, so I'm cleaning that up. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51030115

Summary: This change migrate React-RCTBlob to the new add_dependency to improve its compatibility with macOS and to remove some maintenance burden. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51030365

Summary: This change expose a missing function to create Header Search Paths when a podspec can't depend on another one explicitly. This also migrate the ruby code to this new function. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51068390

Summary: Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that should factor out the platforms from the generation of header search paths. ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51026356

Summary: In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that automate adding a dependency to a podspec and it generates the required search paths. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51027343

Summary: Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that should factor out the platforms from the generation of header search paths. ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51026356

…AppDelegate Summary: This change expose a new API to react_native_pod to add dependencies that automatically configure their search paths when using frameworksa and with multiple Apple platforms. It also migrates React-RCTAppDelegate to this new mechanism to test that it works. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51029484

Summary: React-Core does not depends on any bit of ReactCommon, React-RCTFabric or React-NativeModuleApple, so I'm cleaning that up. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51030115

Summary: This change migrate React-RCTBlob to the new add_dependency to improve its compatibility with macOS and to remove some maintenance burden. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51030365

Summary: This change expose a missing function to create Header Search Paths when a podspec can't depend on another one explicitly. This also migrate the ruby code to this new function. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51068390

Summary: Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that should factor out the platforms from the generation of header search paths. ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51026356

Summary: Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that should factor out the platforms from the generation of header search paths. ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51026356 fbshipit-source-id: 1e0d508481fd83a80eaf8afb85fff84c019e2b3f

Summary: In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that automate adding a dependency to a podspec and it generates the required search paths. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: https://internalfb.com/D51027343 fbshipit-source-id: 687af2f61501d724e546c4de1f365b3edd61afa1

…AppDelegate (facebook#41355) Summary: Pull Request resolved: facebook#41355 This change expose a new API to react_native_pod to add dependencies that automatically configure their search paths when using frameworksa and with multiple Apple platforms. It also migrates React-RCTAppDelegate to this new mechanism to test that it works. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: https://internalfb.com/D51029484 fbshipit-source-id: ff39bb51a0b76c5139dc7f174ea49df7b2d54df4

Summary: React-Core does not depends on any bit of ReactCommon, React-RCTFabric or React-NativeModuleApple, so I'm cleaning that up. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51030115 fbshipit-source-id: c770d922cb43fcbd147a8ed3d3b394f8edc95f13

Summary: This change migrate React-RCTBlob to the new add_dependency to improve its compatibility with macOS and to remove some maintenance burden. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51030365 fbshipit-source-id: a13c5acd65807847a2c9f780b65f9be5e3a034f7

Summary: This change expose a missing function to create Header Search Paths when a podspec can't depend on another one explicitly. This also migrate the ruby code to this new function. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51068390 fbshipit-source-id: c8fcc4d83ce6b8ac10563b0a62a8fe6fd3f799ba

Summary: Pull Request resolved: facebook#41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068403 fbshipit-source-id: ca69263265404fc3fe2f5ca7a0f7e31f8ec54568

Summary: Pull Request resolved: #41353 Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that should factor out the platforms from the generation of header search paths. ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51026356 fbshipit-source-id: 7cf03601d94d7680f3fdfcaf52b2fd6bcd48c5b4

Summary: Pull Request resolved: #41354 In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that automate adding a dependency to a podspec and it generates the required search paths. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51027343 fbshipit-source-id: 33ac4c07112eacb08067220397e38db0a19240fb

…AppDelegate (#41355) Summary: Pull Request resolved: #41355 This change expose a new API to react_native_pod to add dependencies that automatically configure their search paths when using frameworksa and with multiple Apple platforms. It also migrates React-RCTAppDelegate to this new mechanism to test that it works. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51029484 fbshipit-source-id: 77dfe85419d495f7327a2f484d33f9ed8701e00d

Summary: Pull Request resolved: #41356 React-Core does not depends on any bit of ReactCommon, React-RCTFabric or React-NativeModuleApple, so I'm cleaning that up. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51030115 fbshipit-source-id: f87dbfe99e90d52cf8c07057be22cd024e38db42

Summary: Pull Request resolved: #41357 This change migrate React-RCTBlob to the new add_dependency to improve its compatibility with macOS and to remove some maintenance burden. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51030365 fbshipit-source-id: c4b9037d6d0223052d659c04a1f494508944ed2a

…41358) Summary: Pull Request resolved: #41358 This change expose a missing function to create Header Search Paths when a podspec can't depend on another one explicitly. This also migrate the ruby code to this new function. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068390 fbshipit-source-id: ba9e09cd2f0671a9f3f00cc72496a0d5682eeb90

Summary: Pull Request resolved: #41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068403 fbshipit-source-id: 4c0455543363ccf4272d5e8590a7c663d9c33e8b

Summary: Pull Request resolved: #41353 Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that should factor out the platforms from the generation of header search paths. ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51026356 fbshipit-source-id: 7cf03601d94d7680f3fdfcaf52b2fd6bcd48c5b4

Summary: Pull Request resolved: #41354 In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that automate adding a dependency to a podspec and it generates the required search paths. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51027343 fbshipit-source-id: 33ac4c07112eacb08067220397e38db0a19240fb

…AppDelegate (#41355) Summary: Pull Request resolved: #41355 This change expose a new API to react_native_pod to add dependencies that automatically configure their search paths when using frameworksa and with multiple Apple platforms. It also migrates React-RCTAppDelegate to this new mechanism to test that it works. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51029484 fbshipit-source-id: 77dfe85419d495f7327a2f484d33f9ed8701e00d

Summary: Pull Request resolved: #41356 React-Core does not depends on any bit of ReactCommon, React-RCTFabric or React-NativeModuleApple, so I'm cleaning that up. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51030115 fbshipit-source-id: f87dbfe99e90d52cf8c07057be22cd024e38db42

Summary: Pull Request resolved: #41357 This change migrate React-RCTBlob to the new add_dependency to improve its compatibility with macOS and to remove some maintenance burden. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51030365 fbshipit-source-id: c4b9037d6d0223052d659c04a1f494508944ed2a

…41358) Summary: Pull Request resolved: #41358 This change expose a missing function to create Header Search Paths when a podspec can't depend on another one explicitly. This also migrate the ruby code to this new function. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068390 fbshipit-source-id: ba9e09cd2f0671a9f3f00cc72496a0d5682eeb90

Summary: Pull Request resolved: #41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068403 fbshipit-source-id: 4c0455543363ccf4272d5e8590a7c663d9c33e8b

cipolleschi · 2023-11-08T12:42:05Z

facebook#41353 landed and I created facebook#41380 against 0.73.

Once that is merged into the stable branch and react-native-macos is synched with that branch, this pr will just a change in react_native_pods.rb#L70:

def prepare_react_native_project!
  # Temporary solution to suppress duplicated GUID error.
  # Can be removed once we move to generate files outside pod install.
  install! 'cocoapods', :deterministic_uuids => false

  ReactNativePodsUtils.create_xcode_env_if_missing
end

+ $RN_PLATFORMS = ['iOS', 'MacOS']

Summary: Pull Request resolved: facebook#41353 Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that should factor out the platforms from the generation of header search paths. ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51026356 fbshipit-source-id: 7cf03601d94d7680f3fdfcaf52b2fd6bcd48c5b4

Summary: Pull Request resolved: facebook#41354 In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that automate adding a dependency to a podspec and it generates the required search paths. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51027343 fbshipit-source-id: 33ac4c07112eacb08067220397e38db0a19240fb

…AppDelegate (facebook#41355) Summary: Pull Request resolved: facebook#41355 This change expose a new API to react_native_pod to add dependencies that automatically configure their search paths when using frameworksa and with multiple Apple platforms. It also migrates React-RCTAppDelegate to this new mechanism to test that it works. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51029484 fbshipit-source-id: 77dfe85419d495f7327a2f484d33f9ed8701e00d

Summary: Pull Request resolved: facebook#41356 React-Core does not depends on any bit of ReactCommon, React-RCTFabric or React-NativeModuleApple, so I'm cleaning that up. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51030115 fbshipit-source-id: f87dbfe99e90d52cf8c07057be22cd024e38db42

Summary: Pull Request resolved: facebook#41357 This change migrate React-RCTBlob to the new add_dependency to improve its compatibility with macOS and to remove some maintenance burden. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51030365 fbshipit-source-id: c4b9037d6d0223052d659c04a1f494508944ed2a

…acebook#41358) Summary: Pull Request resolved: facebook#41358 This change expose a missing function to create Header Search Paths when a podspec can't depend on another one explicitly. This also migrate the ruby code to this new function. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068390 fbshipit-source-id: ba9e09cd2f0671a9f3f00cc72496a0d5682eeb90

Summary: Pull Request resolved: facebook#41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068403 fbshipit-source-id: 4c0455543363ccf4272d5e8590a7c663d9c33e8b

Saadnajmi · 2024-01-13T21:43:53Z

facebook#41353 landed and I created facebook#41380 against 0.73.

Once that is merged into the stable branch and react-native-macos is synched with that branch, this pr will just a change in react_native_pods.rb#L70:
def prepare_react_native_project!
  # Temporary solution to suppress duplicated GUID error.
  # Can be removed once we move to generate files outside pod install.
  install! 'cocoapods', :deterministic_uuids => false

  ReactNativePodsUtils.create_xcode_env_if_missing
end

+ $RN_PLATFORMS = ['iOS', 'MacOS']

I think we've merged both commits, so I'll try to put up a PR in the coming weeks to add the support. It's lower priority for me right now, so it might be a bit :/

cipolleschi requested a review from a team as a code owner November 2, 2023 19:29

cipolleschi marked this pull request as draft November 2, 2023 19:30

Make RNM work with use_frameworks

52c075e

cipolleschi force-pushed the cipolleschi/macos-use_frameworks branch from c5c99d2 to 52c075e Compare November 2, 2023 19:43

cipolleschi mentioned this pull request Nov 3, 2023

React-Native-MacOS does not support use_frameworks!, :linkage => :dynamic #1969

Open

Make MacOS build with the new Architecture

71d44e4

shwanton mentioned this pull request Nov 3, 2023

[0.73] Fix Paper/Fabric builds not working with USE_FRAMEWORKS=static #1965

Closed

4 tasks

This was referenced Nov 7, 2023

Add helper function to create header_search_path facebook/react-native#41353

Closed

Add helper function to add dependencies facebook/react-native#41354

Closed

This was referenced Nov 7, 2023

Add add_dependency function to ract_native_pods and Migrate React-RCTAppDelegate facebook/react-native#41355

Closed

Cleanup React-Core facebook/react-native#41356

Closed

cipolleschi mentioned this pull request Nov 7, 2023

Migrate React-RCTBlob to add_dependency facebook/react-native#41357

Closed

cipolleschi mentioned this pull request Nov 7, 2023

Expose function to create Header Search Paths and migrate Ruby Code facebook/react-native#41358

Closed

cipolleschi mentioned this pull request Nov 7, 2023

Migrate the remaining Podspec facebook/react-native#41359

Closed

cipolleschi mentioned this pull request Nov 8, 2023

[RN][iOS] Improve Podspec dependencies and prepare support for multiple Apple platforms facebook/react-native#41380

Merged

Saadnajmi force-pushed the 0.73-stable branch from 390b9a1 to 71a3015 Compare January 12, 2024 22:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS][Cocoapods] Make RNM work with use_frameworks #1967

[iOS][Cocoapods] Make RNM work with use_frameworks #1967

cipolleschi commented Nov 2, 2023 •

edited

cipolleschi commented Nov 3, 2023

cipolleschi commented Nov 3, 2023

cipolleschi commented Nov 8, 2023

Saadnajmi commented Jan 13, 2024

[iOS][Cocoapods] Make RNM work with use_frameworks #1967

Are you sure you want to change the base?

[iOS][Cocoapods] Make RNM work with use_frameworks #1967

Conversation

cipolleschi commented Nov 2, 2023 • edited

Please select one of the following

Summary:

Changelog:

Test Plan:

cipolleschi commented Nov 3, 2023

cipolleschi commented Nov 3, 2023

cipolleschi commented Nov 8, 2023

Saadnajmi commented Jan 13, 2024

cipolleschi commented Nov 2, 2023 •

edited