Migrate the remaining Podspec #41359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51068403 |
|
This pull request was exported from Phabricator. Differential Revision: D51068403 |
cipolleschi
force-pushed
the
export-D51068403
branch
from
72cd3cb
to
6cfff0c
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 7, 2023
Summary: Pull Request resolved: facebook#41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51068403 fbshipit-source-id: 316ada6f1c87c10274bdc93b9767513fa996ed7a
|
This pull request was exported from Phabricator. Differential Revision: D51068403 |
cipolleschi
force-pushed
the
export-D51068403
branch
from
6cfff0c
to
b830f25
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 8, 2023
Summary: Pull Request resolved: facebook#41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068403 fbshipit-source-id: 9fc7fd92ad4d607b19b9fe7ebd2bc2742c93ef86
|
This pull request was exported from Phabricator. Differential Revision: D51068403 |
cipolleschi
force-pushed
the
export-D51068403
branch
from
b830f25
to
1721f54
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Nov 8, 2023
Summary: Pull Request resolved: facebook#41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068403 fbshipit-source-id: d9e0f3df46d45691a77de7c113d94222a89e2cbc
Summary: Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that should factor out the platforms from the generation of header search paths. ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51026356 fbshipit-source-id: b9690e9f9699b1e4a914295a8a1303966e045c9e
Summary: Pull Request resolved: facebook#41354 In order to make the infra scalable and avoid a maintenance nightmare for macOS and future platform, we are introducing this function that automate adding a dependency to a podspec and it generates the required search paths. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: https://www.internalfb.com/diff/D51027343?entry_point=27 fbshipit-source-id: dca4f3fb1fd9e15f7f3523b82870c71eb28c8e10
…AppDelegate (facebook#41355) Summary: Pull Request resolved: facebook#41355 This change expose a new API to react_native_pod to add dependencies that automatically configure their search paths when using frameworksa and with multiple Apple platforms. It also migrates React-RCTAppDelegate to this new mechanism to test that it works. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: https://internalfb.com/D51029484 fbshipit-source-id: ff39bb51a0b76c5139dc7f174ea49df7b2d54df4
Summary: React-Core does not depends on any bit of ReactCommon, React-RCTFabric or React-NativeModuleApple, so I'm cleaning that up. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51030115 fbshipit-source-id: c770d922cb43fcbd147a8ed3d3b394f8edc95f13
Summary: This change migrate React-RCTBlob to the new add_dependency to improve its compatibility with macOS and to remove some maintenance burden. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51030365 fbshipit-source-id: a13c5acd65807847a2c9f780b65f9be5e3a034f7
Summary: This change expose a missing function to create Header Search Paths when a podspec can't depend on another one explicitly. This also migrate the ruby code to this new function. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Differential Revision: D51068390 fbshipit-source-id: c8fcc4d83ce6b8ac10563b0a62a8fe6fd3f799ba
Summary: Pull Request resolved: facebook#41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068403 fbshipit-source-id: ca69263265404fc3fe2f5ca7a0f7e31f8ec54568
|
This pull request was exported from Phabricator. Differential Revision: D51068403 |
cipolleschi
force-pushed
the
export-D51068403
branch
from
1721f54
to
37cddcc
Compare
|
This pull request has been merged in 47f773e. |
cipolleschi
added a commit
that referenced
this pull request
Nov 8, 2023
Summary: Pull Request resolved: #41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068403 fbshipit-source-id: 4c0455543363ccf4272d5e8590a7c663d9c33e8b
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41359 This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms. ## Context Last week I helped macOS to work with static framework. When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one. This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated. See also [this PR](microsoft#1967) where I manually make MacOS work with `use_framewroks!` ## Changelog: [Internal] - Add helper function to create header_search_path Reviewed By: shwanton Differential Revision: D51068403 fbshipit-source-id: 4c0455543363ccf4272d5e8590a7c663d9c33e8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change migrates the remaining podspecs to the new functions, so we do not depend on hardcoded values anymore and we can scale the solution to other platforms.
Context
Last week I helped macOS to work with static framework.
When multiple platforms are specified, frameworks are build in two variants, the iOS and macOS one.
This break all the HEADER_SEARCH_PATHS as now we have to properly specify the base folder from which the search path is generated.
See also this PR where I manually make MacOS work with
use_framewroks!Changelog:
[Internal] - Add helper function to create header_search_path
Differential Revision: D51068403