chore: revert noWaitForFinish option, page.close does not wait for ro… #28658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Dec 14, 2023
| @@ -703,7 +701,7 @@ export class RouteHandler { | |||
| // Note that context.route handler may be later invoked on a different page, | |||
| // so we only swallow errors for the current page's routes. | |||
| const handlerActivations = page ? this._activeInvocations.get(page) : [...this._activeInvocations.values()]; | |||
| if (this.noWaitOnUnrouteOrClose || noWait) { | |||
| if (noWait) { | |||
| handlerActivations.forEach(h => h.ignoreException = true); | |||
| } else { | |||
| const promises = []; | |||
There was a problem hiding this comment.
Do we still need the logic below about route._didThrow?
There was a problem hiding this comment.
I believe we do as we should not be waiting for the handlers that threw an error already.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"2 flaky21157 passed, 585 skipped Merge workflow run. |
dgozman
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ute handlers
Reference #23781