Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fulfill/continue/fallback do not throw if page has been closed #28659

Merged
merged 1 commit into from Dec 15, 2023

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Dec 15, 2023

Reference #23781

This comment has been minimized.

@yury-s
Copy link
Member Author

yury-s commented Dec 15, 2023

This depends on #28658

Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [webkit] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live

21188 passed, 569 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit d1e1355 into microsoft:main Dec 15, 2023
30 checks passed
@yury-s yury-s deleted the no-throw-if-page-closed branch December 15, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants