New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wait for active route handlers on page/context close #28414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
yury-s
force-pushed
the
route-auto-remove
branch
from
November 30, 2023 02:22
1933303
to
b9ee467
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dgozman
reviewed
Nov 30, 2023
yury-s
force-pushed
the
route-auto-remove
branch
from
November 30, 2023 23:10
b9ee467
to
b479beb
Compare
dgozman
reviewed
Nov 30, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
force-pushed
the
route-auto-remove
branch
from
December 1, 2023 00:31
6f34c51
to
d4da2d7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yury-s
force-pushed
the
route-auto-remove
branch
from
December 1, 2023 22:58
d1e69d7
to
fc88b92
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
added a commit
that referenced
this pull request
Dec 4, 2023
yury-s
force-pushed
the
route-auto-remove
branch
from
December 4, 2023 21:05
fc88b92
to
11f33b5
Compare
Test results for "tests 1"6 flaky26277 passed, 614 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #23781