Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webkit): delay request event until requestIntercepted is received #28484

Merged
merged 3 commits into from Dec 4, 2023

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Dec 4, 2023

Previously we were wrongly firing route event for the request which are not in fact intercepted (e.g. requests from service worker).

Related #28414
Reference #23781

This comment has been minimized.

@yury-s yury-s force-pushed the no-service-worker-req-intercept branch from fe5f538 to a8ee3ea Compare December 4, 2023 20:25

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Test results for "tests 1"

2 failed
❌ [playwright-test] › playwright.spec.ts:365:5 › should report error from beforeAll timeout
❌ [playwright-test] › playwright.trace.spec.ts:289:5 › should not override trace file in afterAll

6 flaky ⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-ct.spec.ts:113:5 › should run component tests after editing test and component
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [webkit] › page/page-screenshot.spec.ts:671:5 › page screenshot animations › should not capture infinite web animations

26203 passed, 614 skipped
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit ab68d7b into microsoft:main Dec 4, 2023
29 of 30 checks passed
@yury-s yury-s deleted the no-service-worker-req-intercept branch December 4, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants