Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TDSType.GUID (fix) (#1582) #2370

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

vxel
Copy link
Contributor

@vxel vxel commented Mar 27, 2024

This is a fix for the merged and reverted PR #2324.

The original PR intends to provide support for sending UUID parameters as TDSType.GUID (0x24) on the wire and (hopefully) implements feature request #1582.
It currently requires the Java parameter be given to the driver as String with JDBCType.GUID, i.e. :

st.setObject(index, myUUID.toString(), microsoft.sql.Types.GUID);

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 50.07%. Comparing base (8e92248) to head (b06ed6a).
Report is 5 commits behind head on main.

❗ Current head b06ed6a differs from pull request most recent head 429ad6b. Consider uploading reports for the commit 429ad6b to get more accurate results

Files Patch % Lines
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.63% 2 Missing and 2 partials ⚠️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2370      +/-   ##
============================================
- Coverage     50.10%   50.07%   -0.03%     
- Complexity     3813     3817       +4     
============================================
  Files           145      145              
  Lines         33286    33319      +33     
  Branches       5639     5644       +5     
============================================
+ Hits          16677    16684       +7     
- Misses        14221    14254      +33     
+ Partials       2388     2381       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilgreenbird lilgreenbird added this to In progress in MSSQL JDBC via automation Mar 28, 2024
lilgreenbird
lilgreenbird previously approved these changes Apr 1, 2024
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Apr 1, 2024
MSSQL JDBC automation moved this from Under Peer Review to In progress Apr 1, 2024
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Apr 1, 2024
@lilgreenbird lilgreenbird added this to the 12.7.0 milestone Apr 1, 2024
@lilgreenbird lilgreenbird linked an issue Apr 1, 2024 that may be closed by this pull request
@vxel
Copy link
Contributor Author

vxel commented Apr 2, 2024

@lilgreenbird Thanks for the correction. I wasn't aware of this Azure SQL Data Warehouse limitation.

@lilgreenbird lilgreenbird merged commit 30f2ae0 into microsoft:main Apr 2, 2024
17 checks passed
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Apr 2, 2024
@vxel vxel deleted the feature/guid branch May 10, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Allow sending UUID in binary to database
4 participants