-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for JavaType.UUID (#1582) #2412
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2412 +/- ##
============================================
- Coverage 50.25% 50.05% -0.20%
+ Complexity 3857 3830 -27
============================================
Files 145 145
Lines 33355 33402 +47
Branches 5654 5663 +9
============================================
- Hits 16764 16721 -43
- Misses 14213 14281 +68
- Partials 2378 2400 +22 ☔ View full report in Codecov by Sentry. |
Please note that, in order to cover the UUID conversions, I updated a couple of AlwaysEncrypted unit tests. |
@vxel This might help: https://github.com/microsoft/mssql-jdbc/wiki/How-to-run-Always-Encrypted-tests-locally |
Thank you @David-Engel for the link. Yes, this PR is failing on our AE tests in our internal pipeline, please correct this before we review. The above link should help in allowing you to setup and test AE tests locally. |
Thank you for the link, I will take a look ! |
This PR relates to feature request #1582 and follows pull request #2370.
While PR #2370 allowed sending UUID as TDSType.GUID on the wire, it still required the UUID be passed as String to the statement
setObject()
method.This PR aims at providing support for the UUID Java type as parameter for the
setObject()
method and hence complete feature request #1582.Example :
pstmt.setObject(1, UUID.randomUUID())