New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed auth DLL with driver #2094

Merged

tkyc merged 7 commits into main from embed-auth-dll

Mar 29, 2023

Member

tkyc commented Mar 20, 2023

No description provided.

tkyc requested review from lilgreenbird and Jeffery-Wasty

March 20, 2023 22:18

tkyc force-pushed the embed-auth-dll branch from 1faafc8 to f204ef1 Compare

March 20, 2023 22:25


          Embed auth DLL into driver

8d6e9f8

tkyc force-pushed the embed-auth-dll branch from f204ef1 to 8d6e9f8 Compare

March 21, 2023 19:45

tkyc added 2 commits

March 21, 2023 13:48


          Added comment

527e46d


          Added 32bit DLL

0d268ba

Jeffery-Wasty reviewed

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Outdated Show resolved Hide resolved

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Outdated Show resolved Hide resolved

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Outdated Show resolved Hide resolved

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Outdated Show resolved Hide resolved


          PR comments

9ecb222

Jeffery-Wasty previously approved these changes

View reviewed changes

lilgreenbird reviewed

View reviewed changes

pom.xml Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/testframework/Constants.java Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/connection/ConnectionTest.java Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Outdated Show resolved Hide resolved

lilgreenbird reviewed

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/AuthenticationJNI.java Outdated Show resolved Hide resolved

lilgreenbird added this to In progress in MSSQL JDBC via automation

lilgreenbird added this to the 12.3.0 milestone

lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC


          PR comments pt.2

2f4cc76

tkyc dismissed Jeffery-Wasty’s stale review via

2f4cc76

March 27, 2023 18:51

MSSQL JDBC automation moved this from Under Peer Review to In progress

tkyc added 2 commits

March 27, 2023 12:17


          PR comments pt.3

e407306


          Removed use of unavailable method in Java 8

32ddf73

lilgreenbird approved these changes

View reviewed changes

lilgreenbird linked an issue

that may be closed by this pull request

Make name of mssql-jdbc_auth DLL stable or configurable #1850

Open

This was linked to issues Mar 28, 2023

Publish x64 version auth dll with amd64 suffix to match os.arch #1905

Open

Provide maven library for integrated authentication #1617

Open

lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC

Jeffery-Wasty approved these changes

View reviewed changes

tkyc merged commit c3538fd into main

21 checks passed

MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs

tkyc deleted the embed-auth-dll branch

March 29, 2023 16:46

tkyc added a commit that referenced this pull request


          Revert "Embed auth DLL with driver (#2094)"

9efef39

This reverts commit c3538fd.

This was unlinked from issues Apr 18, 2023

Provide maven library for integrated authentication #1617

Open

Make name of mssql-jdbc_auth DLL stable or configurable #1850

Open

Publish x64 version auth dll with amd64 suffix to match os.arch #1905

Open

tkyc added a commit that referenced this pull request


          Embed auth dll revert (#2109)

150effe

* Revert "fix (#2105)"

This reverts commit 180c97d.

* Revert "Embed auth DLL with driver (#2094)"

This reverts commit c3538fd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment