Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish x64 version auth dll with amd64 suffix to match os.arch #1905

Open
mwisnicki opened this issue Aug 24, 2022 · 8 comments
Open

Publish x64 version auth dll with amd64 suffix to match os.arch #1905

mwisnicki opened this issue Aug 24, 2022 · 8 comments
Labels
Backlog The topic in question has been recognized and added to development backlog Enhancement An enhancement to the driver. Lower priority than bugs.
Projects

Comments

@mwisnicki
Copy link

Can you change arch suffix of x64 version to amd64 such that it matches ${os.arch}?

This will make usage a bit easier:

<dependency>
    <groupId>com.microsoft.sqlserver</groupId>
    <artifactId>mssql-jdbc_auth</artifactId>
    <version>11.2.0.${os.arch}</version>
    <type>dll</type>
</dependency>

Otherwise I have to have an extra maven profile to map os.arch to suffix.

@mwisnicki mwisnicki changed the title Publish x64 version Sqljdbc Auth with amd64 suffix to match os.arch Publish x64 version auth dll with amd64 suffix to match os.arch Aug 24, 2022
@Jeffery-Wasty
Copy link
Member

Hi @mwisnicki,

We can take a look at this in our upcoming triage, but generally small-scale enhancements like this are lower priority. If we end up addressing this, we may look at making the auth.dll names configurable, such as is suggested in #1850. Outright changing the name is probably not happening.

@mwisnicki
Copy link
Author

Hey, thanks for reply. I don't think making names configurable at runtime changes anything with regard to this request as the artifact published in maven still needs to be named uniquely (unless you change how you distribute dlls).

@Jeffery-Wasty
Copy link
Member

That was also discussed as part of the issue. Regardless, we'll take a look at all of our naming at a later time.

@Jeffery-Wasty Jeffery-Wasty added the Backlog The topic in question has been recognized and added to development backlog label Aug 25, 2022
@lilgreenbird
Copy link
Member

hi @mwisnicki

ultimately we would like to get rid of the DLLs all together however we are currently blocked by issue AzureAD/microsoft-authentication-library-for-java#299. Once that's available we will be working towards moving all the DLL functionalities into the Java code so we can get rid of all the DLLs.

@lilgreenbird lilgreenbird added this to Under Investigation in MSSQL JDBC via automation Aug 25, 2022
@lilgreenbird lilgreenbird added the Enhancement An enhancement to the driver. Lower priority than bugs. label Aug 25, 2022
@lilgreenbird lilgreenbird moved this from Under Investigation to Backlog in MSSQL JDBC Aug 25, 2022
@TarasTielkes
Copy link

Will a Windows arm64 version of mssql-jdbc_auth be provided in a future release?

@Jeffery-Wasty
Copy link
Member

@lilgreenbird's comment above still stands, our next goal regarding these auth DLLs is their removal entirely, however we're still blocked by the PR mentioned above.

@TarasTielkes
Copy link

TarasTielkes commented Nov 10, 2022

Out of curiosity, how does/would microsoft-authentication-library-for-java eliminate the need for JNI to call crypt/advapi?

@Jeffery-Wasty
Copy link
Member

You're right, I completely misread your comment, my mistake.

Right now, we are not working on a Windows ARM64 version of the auth dll, but this is something we can look at again during our next planning session.

@lilgreenbird lilgreenbird linked a pull request Mar 28, 2023 that will close this issue
MSSQL JDBC automation moved this from Backlog to Closed Issues Mar 29, 2023
@tkyc tkyc reopened this Apr 12, 2023
MSSQL JDBC automation moved this from Closed Issues to Under Investigation Apr 12, 2023
@lilgreenbird lilgreenbird removed a link to a pull request Apr 18, 2023
@lilgreenbird lilgreenbird moved this from Under Investigation to Backlog in MSSQL JDBC Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog The topic in question has been recognized and added to development backlog Enhancement An enhancement to the driver. Lower priority than bugs.
Projects
MSSQL JDBC
  
Backlog
Development

No branches or pull requests

5 participants