chore: improve React 18 support #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spmonahan
reviewed
Mar 15, 2022
| import * as React from 'react'; | ||
|
|
||
| // @ts-expect-error | ||
| export const useInsertionEffect = React['useInsertion' + 'Effect'] |
There was a problem hiding this comment.
Looks like this string concat is done to prevent issues with transpiling/bundling. Would be nice to have a comment explaining this, it wasn't obvious to me until I read this emotion PR.
layershifter
force-pushed
the
feat/react-18-support
branch
from
37438c6
to
c0dac7e
Compare
📊 Bundle size report
Unchanged fixtures
|
layershifter
force-pushed
the
feat/react-18-support
branch
3 times, most recently
from
f97f479
to
dd1d4e7
Compare
ling1726
reviewed
Jul 18, 2023
packages/core/src/makeStyles.ts
Outdated
| renderer.insertCSSRules(cssRules!); | ||
| insertionCache[rendererId] = true; | ||
| } | ||
| insertStyles(renderer, dir, cssRules!); |
There was a problem hiding this comment.
nit: maybe at this point the computeClasses function name above was never quite clear. This step does not only compute the classes but also inserts them to DOM
layershifter
force-pushed
the
feat/react-18-support
branch
2 times, most recently
from
ab3c8ed
to
d12c92d
Compare
layershifter
changed the title
ling1726
reviewed
Jul 28, 2023
ling1726
approved these changes
Jul 28, 2023
layershifter
force-pushed
the
feat/react-18-support
branch
from
d12c92d
to
8b59d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40.
This PR improves compatibility of
@griffel/reactby using a custom insertion factory that usesuseInsertionEffectwhen it's available.