chore: Update Griffel to latest version #28684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
a team,
sopranopillow,
GeoffCoxMSFT,
khmakoto,
Mitch-At-Work,
tomi-msft,
ms-acalzaretto,
chpalac,
ling1726,
behowell,
spmonahan,
micahgodbolt and
smhigley
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2060810:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 81 | 73 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 618 | 585 | 5000 | |
| Button | mount | 305 | 309 | 5000 | |
| Field | mount | 1079 | 1087 | 5000 | |
| FluentProvider | mount | 682 | 659 | 5000 | |
| FluentProviderWithTheme | mount | 75 | 84 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 73 | 74 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 81 | 73 | 10 | Possible regression |
| InfoButton | mount | 16 | 17 | 5000 | |
| MakeStyles | mount | 868 | 870 | 50000 | |
| Persona | mount | 1704 | 1676 | 5000 | |
| SpinButton | mount | 1335 | 1378 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 98 | 80 | 1.23:1 |
| TreeWith60ListItems.default | 90 | 82 | 1.1:1 |
| SegmentMinimalPerf.default | 211 | 197 | 1.07:1 |
| AttachmentMinimalPerf.default | 86 | 81 | 1.06:1 |
| ChatWithPopoverPerf.default | 202 | 190 | 1.06:1 |
| CarouselMinimalPerf.default | 266 | 253 | 1.05:1 |
| TooltipMinimalPerf.default | 1304 | 1240 | 1.05:1 |
| CheckboxMinimalPerf.default | 1177 | 1128 | 1.04:1 |
| GridMinimalPerf.default | 191 | 183 | 1.04:1 |
| HeaderMinimalPerf.default | 210 | 202 | 1.04:1 |
| CardMinimalPerf.default | 307 | 297 | 1.03:1 |
| ListMinimalPerf.default | 308 | 298 | 1.03:1 |
| ListNestedPerf.default | 316 | 308 | 1.03:1 |
| MenuButtonMinimalPerf.default | 970 | 938 | 1.03:1 |
| TableManyItemsPerf.default | 1132 | 1100 | 1.03:1 |
| BoxMinimalPerf.default | 194 | 191 | 1.02:1 |
| InputMinimalPerf.default | 543 | 534 | 1.02:1 |
| ListCommonPerf.default | 392 | 383 | 1.02:1 |
| ProviderMergeThemesPerf.default | 671 | 660 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2289 | 2251 | 1.02:1 |
| AnimationMinimalPerf.default | 300 | 298 | 1.01:1 |
| DatepickerMinimalPerf.default | 3728 | 3673 | 1.01:1 |
| DialogMinimalPerf.default | 438 | 434 | 1.01:1 |
| HeaderSlotsPerf.default | 464 | 459 | 1.01:1 |
| PopupMinimalPerf.default | 355 | 351 | 1.01:1 |
| SliderMinimalPerf.default | 730 | 726 | 1.01:1 |
| ToolbarMinimalPerf.default | 532 | 526 | 1.01:1 |
| AttachmentSlotsPerf.default | 622 | 625 | 1:1 |
| AvatarMinimalPerf.default | 106 | 106 | 1:1 |
| DividerMinimalPerf.default | 201 | 202 | 1:1 |
| EmbedMinimalPerf.default | 1850 | 1841 | 1:1 |
| ImageMinimalPerf.default | 220 | 221 | 1:1 |
| ItemLayoutMinimalPerf.default | 700 | 700 | 1:1 |
| LoaderMinimalPerf.default | 190 | 190 | 1:1 |
| RadioGroupMinimalPerf.default | 258 | 257 | 1:1 |
| SkeletonMinimalPerf.default | 202 | 202 | 1:1 |
| TableMinimalPerf.default | 236 | 236 | 1:1 |
| CustomToolbarPrototype.default | 1456 | 1456 | 1:1 |
| AccordionMinimalPerf.default | 78 | 79 | 0.99:1 |
| MenuMinimalPerf.default | 489 | 495 | 0.99:1 |
| RosterPerf.default | 1520 | 1542 | 0.99:1 |
| PortalMinimalPerf.default | 82 | 83 | 0.99:1 |
| ProviderMinimalPerf.default | 196 | 197 | 0.99:1 |
| ReactionMinimalPerf.default | 206 | 209 | 0.99:1 |
| IconMinimalPerf.default | 388 | 390 | 0.99:1 |
| TreeMinimalPerf.default | 469 | 475 | 0.99:1 |
| ButtonOverridesMissPerf.default | 638 | 649 | 0.98:1 |
| ChatMinimalPerf.default | 441 | 448 | 0.98:1 |
| DropdownManyItemsPerf.default | 379 | 388 | 0.98:1 |
| DropdownMinimalPerf.default | 1395 | 1422 | 0.98:1 |
| FormMinimalPerf.default | 225 | 229 | 0.98:1 |
| TextAreaMinimalPerf.default | 279 | 286 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 150 | 155 | 0.97:1 |
| FlexMinimalPerf.default | 150 | 155 | 0.97:1 |
| LabelMinimalPerf.default | 221 | 227 | 0.97:1 |
| ButtonSlotsPerf.default | 299 | 311 | 0.96:1 |
| ListWith60ListItems.default | 346 | 359 | 0.96:1 |
| RefMinimalPerf.default | 107 | 111 | 0.96:1 |
| StatusMinimalPerf.default | 376 | 391 | 0.96:1 |
| TextMinimalPerf.default | 191 | 198 | 0.96:1 |
| VideoMinimalPerf.default | 423 | 439 | 0.96:1 |
| AlertMinimalPerf.default | 149 | 159 | 0.94:1 |
| LayoutMinimalPerf.default | 189 | 205 | 0.92:1 |
📊 Bundle size report
Unchanged fixtures
|
🕵 FluentUIV0 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 90b6ff33ce9719a1e07487f05c6d38e414b6cc40 (build) |
🕵 fluentuiv9 No visual regressions between this PR and main |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 619 | 633 | 5000 | |
| Breadcrumb | mount | 1687 | 1644 | 1000 | |
| Checkbox | mount | 1654 | 1705 | 5000 | |
| CheckboxBase | mount | 1487 | 1491 | 5000 | |
| ChoiceGroup | mount | 2944 | 2948 | 5000 | |
| ComboBox | mount | 679 | 653 | 1000 | |
| CommandBar | mount | 6167 | 6240 | 1000 | |
| ContextualMenu | mount | 13313 | 13112 | 1000 | |
| DefaultButton | mount | 734 | 730 | 5000 | |
| DetailsRow | mount | 2164 | 2192 | 5000 | |
| DetailsRowFast | mount | 2187 | 2151 | 5000 | |
| DetailsRowNoStyles | mount | 2000 | 2012 | 5000 | |
| Dialog | mount | 2774 | 2660 | 1000 | |
| DocumentCardTitle | mount | 230 | 236 | 1000 | |
| Dropdown | mount | 2044 | 1995 | 5000 | |
| FocusTrapZone | mount | 1117 | 1108 | 5000 | |
| FocusZone | mount | 1081 | 1044 | 5000 | |
| GroupedList | mount | 41022 | 41274 | 2 | |
| GroupedList | virtual-rerender | 19719 | 19846 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50370 | 50337 | 2 | |
| GroupedListV2 | mount | 225 | 223 | 2 | |
| GroupedListV2 | virtual-rerender | 212 | 206 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 233 | 221 | 2 | |
| IconButton | mount | 1039 | 1064 | 5000 | |
| Label | mount | 334 | 350 | 5000 | |
| Layer | mount | 2704 | 2675 | 5000 | |
| Link | mount | 385 | 378 | 5000 | |
| MenuButton | mount | 921 | 968 | 5000 | |
| MessageBar | mount | 21301 | 21283 | 5000 | |
| Nav | mount | 1954 | 1890 | 1000 | |
| OverflowSet | mount | 762 | 767 | 5000 | |
| Panel | mount | 1776 | 1798 | 1000 | |
| Persona | mount | 746 | 717 | 1000 | |
| Pivot | mount | 880 | 862 | 1000 | |
| PrimaryButton | mount | 834 | 857 | 5000 | |
| Rating | mount | 4525 | 4621 | 5000 | |
| SearchBox | mount | 889 | 920 | 5000 | |
| Shimmer | mount | 1850 | 1862 | 5000 | |
| Slider | mount | 1306 | 1299 | 5000 | |
| SpinButton | mount | 2940 | 2900 | 5000 | |
| Spinner | mount | 387 | 386 | 5000 | |
| SplitButton | mount | 1779 | 1792 | 5000 | |
| Stack | mount | 402 | 432 | 5000 | |
| StackWithIntrinsicChildren | mount | 864 | 876 | 5000 | |
| StackWithTextChildren | mount | 2610 | 2591 | 5000 | |
| SwatchColorPicker | mount | 6008 | 5965 | 5000 | |
| TagPicker | mount | 1448 | 1450 | 5000 | |
| Text | mount | 373 | 383 | 5000 | |
| TextField | mount | 947 | 907 | 5000 | |
| ThemeProvider | mount | 812 | 811 | 5000 | |
| ThemeProvider | virtual-rerender | 574 | 594 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1286 | 1262 | 5000 | |
| Toggle | mount | 594 | 608 | 5000 | |
| buttonNative | mount | 196 | 190 | 5000 |
ling1726
approved these changes
Jul 31, 2023
behowell
approved these changes
Jul 31, 2023
spmonahan
approved these changes
Jul 31, 2023
khmakoto
approved these changes
Jul 31, 2023
tudorpopams
approved these changes
Aug 1, 2023
layershifter
force-pushed
the
chore/bump-griffel
branch
from
d6a3ecb
to
d991197
Compare
github-actions
bot
modified the milestones:
July Project Cycle Q3 2023,
August Project Cycle Q4 2023
layershifter
force-pushed
the
chore/bump-griffel
branch
from
d991197
to
2060810
Compare
fabricteam
reviewed
Aug 8, 2023
|
Force merged as approvals from all team members are present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps Griffel dependencies to fix #28552, get better types (microsoft/griffel#70), improved React 18 support (microsoft/griffel#72) and reduced bundle size (microsoft/griffel#388).
Related Issue(s)
Fixes #28552