Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react: Better support for React 18 #40

Closed
1 task done
layershifter opened this issue Feb 21, 2022 · 1 comment · Fixed by #72
Closed
1 task done

react: Better support for React 18 #40

layershifter opened this issue Feb 21, 2022 · 1 comment · Fixed by #72
Assignees
Labels
💅 enhancement New feature or request

Comments

@layershifter
Copy link
Member

layershifter commented Feb 21, 2022

RC for React 18 is already published:

image


NOTE: Make sure you read the section "When to Insert <style> on The Client". If you currently inject style rules "during render", it could make your library VERY slow in concurrent rendering.
reactwg/react-18#110

In short we should use useInsertionEffect to apply our styles to DOM.

For reference:

@layershifter layershifter added the 💅 enhancement New feature or request label Feb 21, 2022
@layershifter layershifter self-assigned this Feb 23, 2022
@layershifter layershifter changed the title Better support for React 18 react: Better support for React 18 Jul 22, 2022
@layershifter
Copy link
Member Author

At this point, we are focused on implementing useInsertionEffect API. Streaming API will be implemented later based on requests, https://react.dev/reference/react-dom/server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💅 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant