Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow React 18 in peerDependencies #262

Closed
nahumzs opened this issue Oct 25, 2022 · 2 comments · Fixed by #263
Closed

Allow React 18 in peerDependencies #262

nahumzs opened this issue Oct 25, 2022 · 2 comments · Fixed by #263

Comments

@nahumzs
Copy link

nahumzs commented Oct 25, 2022

Fluent UI library has already merged, and I would think soonish to release support for react 18; any chance griffle will update the peer dependency sooner and make it compatible with react 18?

microsoft/fluentui#22241

https://github.com/microsoft/griffel/blob/main/packages/react/package.json#L16
@layershifter layershifter changed the title React 18 support Allow React 18 in peerDependencies Oct 26, 2022
@layershifter
Copy link
Member

Hey, there are some improvements that we need to make for React 18 (#40). But overall - it works, so there are no reasons to not allow React 18 in peerDependencies. I will create a PR.

@layershifter layershifter mentioned this issue Oct 26, 2022
Merged
@layershifter
Copy link
Member

Released in @griffel/react@1.4.2.

@nahumzs nahumzs mentioned this issue Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: allow React 18 in peerDependencies layershifter/griffel
2 participants
@layershifter @nahumzs