Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ado-gha-axe-core): Add Job Summary to GH Action #1204

Merged
merged 2 commits into from Jun 13, 2022

Conversation

brocktaylor7
Copy link
Contributor

Details

This PR adds the new Job Summary functionality to the Github Action

Here is a link to a test action run that uses the job summary, you can find it under "build summary" at the bottom of the summary tab:
https://github.com/brocktaylor7/accessibility-insights-action-test/actions/runs/2471620857

image

Motivation

Feature work.

Context

I spent some time looking into whether we could directly link the artifact within the job summary. Because the artifact upload happens in a subsequent step in the Github Action, the artifact doesn't yet exist when the job summary is being created and thus can't be linked.

There will be a separate PR that removes the check run and token. We may also need to look into whether we need to fail the build in that step when accessibility issues are found, as I believe the current place that the build fails is within the check run step.

This PR has no impact on the ADO Extension.

Pull request checklist

  • [n/a] Addresses an existing issue: Fixes #0000
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • Described how this PR impacts both the ADO extension and the GitHub action

@brocktaylor7 brocktaylor7 requested a review from a team as a code owner June 10, 2022 17:38
@codecov-commenter
Copy link

Codecov Report

Merging #1204 (99156dc) into main (0636b80) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
+ Coverage   89.93%   90.09%   +0.15%     
==========================================
  Files          62       63       +1     
  Lines        1580     1605      +25     
  Branches      200      200              
==========================================
+ Hits         1421     1446      +25     
  Misses        159      159              
Impacted Files Coverage Δ
packages/gh-action/src/ioc/setup-ioc-container.ts 100.00% <100.00%> (ø)
...s/gh-action/src/job-summary/job-summary-creator.ts 100.00% <100.00%> (ø)
...ckages/gh-action/src/task-config/gh-task-config.ts 91.04% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0636b80...99156dc. Read the comment docs.

Copy link
Contributor

@lisli1 lisli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but LGTM!

@brocktaylor7 brocktaylor7 merged commit 3c4d60e into main Jun 13, 2022
@brocktaylor7 brocktaylor7 deleted the brocktaylor/job-summary-creator branch June 13, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants