Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(ado-gha-axe-core): Add Job Summary to GH Action (#1204)
* add job summary creator * swap smarkdownSummary for summary due to deprecation
- Loading branch information
1 parent
6b4e71f
commit 3c4d60e
Showing
5 changed files
with
125 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
packages/gh-action/src/job-summary/job-summary-creator.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
import 'reflect-metadata'; | ||
import { IMock, Mock } from 'typemoq'; | ||
import { Logger, ReportMarkdownConvertor } from '@accessibility-insights-action/shared'; | ||
import { CombinedReportParameters } from 'accessibility-insights-report'; | ||
import { JobSummaryCreator } from './job-summary-creator'; | ||
import { GHTaskConfig } from '../task-config/gh-task-config'; | ||
|
||
describe(JobSummaryCreator, () => { | ||
let testSubject: JobSummaryCreator; | ||
let reportMarkdownConvertorMock: IMock<ReportMarkdownConvertor>; | ||
let loggerMock: IMock<Logger>; | ||
let taskConfigMock: IMock<GHTaskConfig>; | ||
|
||
const markdownContent = 'test markdown content'; | ||
const combinedReportResult = { serviceName: 'combinedReportResult' } as CombinedReportParameters; | ||
|
||
beforeEach(() => { | ||
taskConfigMock = Mock.ofType<GHTaskConfig>(); | ||
reportMarkdownConvertorMock = Mock.ofType(ReportMarkdownConvertor); | ||
loggerMock = Mock.ofType(Logger); | ||
testSubject = new JobSummaryCreator(taskConfigMock.object, reportMarkdownConvertorMock.object, loggerMock.object); | ||
}); | ||
|
||
afterEach(() => { | ||
reportMarkdownConvertorMock.verifyAll(); | ||
loggerMock.verifyAll(); | ||
}); | ||
|
||
describe('start', () => { | ||
it('does nothing', async () => { | ||
await expect(testSubject.start()).resolves.toBeUndefined(); | ||
}); | ||
}); | ||
|
||
describe('didScanSucceed', () => { | ||
it('returns true by default', async () => { | ||
await expect(testSubject.didScanSucceed()).resolves.toBe(true); | ||
}); | ||
|
||
it('returns false after failRun() is called', async () => { | ||
await testSubject.failRun(); | ||
await expect(testSubject.didScanSucceed()).resolves.toBe(false); | ||
}); | ||
}); | ||
|
||
describe('completeRun', () => { | ||
it('converts to markdown and writes the job summary', async () => { | ||
reportMarkdownConvertorMock | ||
.setup((a) => a.convert(combinedReportResult)) | ||
.returns(() => markdownContent) | ||
.verifiable(); | ||
taskConfigMock | ||
.setup((a) => a.writeJobSummary(markdownContent)) | ||
.returns(() => Promise.resolve()) | ||
.verifiable(); | ||
await testSubject.completeRun(combinedReportResult); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT License. | ||
|
||
import { inject, injectable } from 'inversify'; | ||
import { iocTypes, Logger, ProgressReporter, ReportMarkdownConvertor } from '@accessibility-insights-action/shared'; | ||
import { CombinedReportParameters } from 'accessibility-insights-report'; | ||
import { GHTaskConfig } from '../task-config/gh-task-config'; | ||
|
||
@injectable() | ||
export class JobSummaryCreator extends ProgressReporter { | ||
private scanSucceeded = true; | ||
|
||
constructor( | ||
@inject(iocTypes.TaskConfig) private readonly taskConfig: GHTaskConfig, | ||
@inject(ReportMarkdownConvertor) private readonly reportMarkdownConvertor: ReportMarkdownConvertor, | ||
@inject(Logger) private readonly logger: Logger, | ||
) { | ||
super(); | ||
} | ||
|
||
public start(): Promise<void> { | ||
this.logger.logDebug('job summary creator started'); | ||
return Promise.resolve(); | ||
} | ||
|
||
public async completeRun(combinedReportResult: CombinedReportParameters): Promise<void> { | ||
const reportMarkdown = this.reportMarkdownConvertor.convert(combinedReportResult); | ||
return await this.taskConfig.writeJobSummary(reportMarkdown); | ||
} | ||
|
||
// eslint-disable-next-line @typescript-eslint/require-await | ||
public async failRun(): Promise<void> { | ||
this.scanSucceeded = false; | ||
} | ||
|
||
public didScanSucceed(): Promise<boolean> { | ||
return Promise.resolve(this.scanSucceeded); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters