Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emit WebAssembly types separately from DOM types #959

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Dec 2, 2020

Fixes #826


Note that I’d prefer if there was a way to filter based on the source WebIDL file, rather than the current Flavor const enum approach. This now uses a custom Exposed value of WebAssembly, which is less hackish.

Also, namespace WebAssembly should be omitted from dom and webworker apart from compileStreaming and instantiateStreaming, which is why this leaves #826 open.

Depends on:

See also:


review?(@saschanaz)

src/helpers.ts Outdated Show resolved Hide resolved
@ExE-Boss ExE-Boss marked this pull request as draft December 14, 2020 07:58
@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Dec 14, 2020

I’ve marked this as a draft, because this depends on #962 and #963.

@saltman424
Copy link

@sandersn Any chance this can get reviewed?

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Feb 21, 2024

@saltman424
This PR needs to be redone, as there were many changes to this since I last touched this.

@ExE-Boss ExE-Boss marked this pull request as draft February 21, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate WebAssembly types from lib.dom.d.ts into their own file
3 participants