fix(WebAssembly): Fix WebAssembly NativeError types

microsoft · Dec 2, 2020 · 9804caf · 9804caf
1 parent ac1855b
commit 9804caf
Show file tree

Hide file tree

Showing 5 changed files with 75 additions and 15 deletions.
diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts
@@ -19053,12 +19053,13 @@ declare namespace CSS {
 }
 
 declare namespace WebAssembly {
-    interface CompileError {
+    interface CompileError extends Error {
     }
 
     var CompileError: {
         prototype: CompileError;
-        new(): CompileError;
+        new(message?: string): CompileError;
+        (message?: string): CompileError;
     };
 
     interface Global {
@@ -19080,12 +19081,13 @@ declare namespace WebAssembly {
         new(module: Module, importObject?: Imports): Instance;
     };
 
-    interface LinkError {
+    interface LinkError extends Error {
     }
 
     var LinkError: {
         prototype: LinkError;
-        new(): LinkError;
+        new(message?: string): LinkError;
+        (message?: string): LinkError;
     };
 
     interface Memory {
@@ -19109,12 +19111,13 @@ declare namespace WebAssembly {
         imports(moduleObject: Module): ModuleImportDescriptor[];
     };
 
-    interface RuntimeError {
+    interface RuntimeError extends Error {
     }
 
     var RuntimeError: {
         prototype: RuntimeError;
-        new(): RuntimeError;
+        new(message?: string): RuntimeError;
+        (message?: string): RuntimeError;
     };
 
     interface Table {

diff --git a/baselines/webassembly.generated.d.ts b/baselines/webassembly.generated.d.ts
@@ -3,12 +3,13 @@
 /////////////////////////////
 
 declare namespace WebAssembly {
-    interface CompileError {
+    interface CompileError extends Error {
     }
 
     var CompileError: {
         prototype: CompileError;
-        new(): CompileError;
+        new(message?: string): CompileError;
+        (message?: string): CompileError;
     };
 
     interface Global {
@@ -30,12 +31,13 @@ declare namespace WebAssembly {
         new(module: Module, importObject?: Imports): Instance;
     };
 
-    interface LinkError {
+    interface LinkError extends Error {
     }
 
     var LinkError: {
         prototype: LinkError;
-        new(): LinkError;
+        new(message?: string): LinkError;
+        (message?: string): LinkError;
     };
 
     interface Memory {
@@ -59,12 +61,13 @@ declare namespace WebAssembly {
         imports(moduleObject: Module): ModuleImportDescriptor[];
     };
 
-    interface RuntimeError {
+    interface RuntimeError extends Error {
     }
 
     var RuntimeError: {
         prototype: RuntimeError;
-        new(): RuntimeError;
+        new(message?: string): RuntimeError;
+        (message?: string): RuntimeError;
     };
 
     interface Table {

diff --git a/baselines/webworker.generated.d.ts b/baselines/webworker.generated.d.ts
@@ -5744,6 +5744,15 @@ interface Console {
 declare var console: Console;
 
 declare namespace WebAssembly {
+    interface CompileError extends Error {
+    }
+
+    var CompileError: {
+        prototype: CompileError;
+        new(message?: string): CompileError;
+        (message?: string): CompileError;
+    };
+
     interface Global {
         value: any;
         valueOf(): any;
@@ -5763,6 +5772,15 @@ declare namespace WebAssembly {
         new(module: Module, importObject?: Imports): Instance;
     };
 
+    interface LinkError extends Error {
+    }
+
+    var LinkError: {
+        prototype: LinkError;
+        new(message?: string): LinkError;
+        (message?: string): LinkError;
+    };
+
     interface Memory {
         readonly buffer: ArrayBuffer;
         grow(delta: number): number;
@@ -5784,6 +5802,15 @@ declare namespace WebAssembly {
         imports(moduleObject: Module): ModuleImportDescriptor[];
     };
 
+    interface RuntimeError extends Error {
+    }
+
+    var RuntimeError: {
+        prototype: RuntimeError;
+        new(message?: string): RuntimeError;
+        (message?: string): RuntimeError;
+    };
+
     interface Table {
         readonly length: number;
         get(index: number): Function | null;

diff --git a/inputfiles/idl/WebAssembly JavaScript Interface.widl b/inputfiles/idl/WebAssembly JavaScript Interface.widl
@@ -95,11 +95,11 @@ interface Global {
   attribute any value;
 };
 
-[LegacyNamespace=WebAssembly]
+[LegacyNamespace=WebAssembly, Exposed=(Window,Worker,Worklet)]
 interface CompileError { };
 
-[LegacyNamespace=WebAssembly]
+[LegacyNamespace=WebAssembly, Exposed=(Window,Worker,Worklet)]
 interface LinkError { };
 
-[LegacyNamespace=WebAssembly]
+[LegacyNamespace=WebAssembly, Exposed=(Window,Worker,Worklet)]
 interface RuntimeError { };
diff --git a/inputfiles/overridingTypes.json b/inputfiles/overridingTypes.json
@@ -2566,6 +2566,33 @@
                         }
                     }
                 }
+            },
+            "CompileError": {
+                "extends": "Error",
+                "constructor": {
+                    "override-signatures": [
+                        "new(message?: string): CompileError",
+                        "(message?: string): CompileError"
+                    ]
+                }
+            },
+            "LinkError": {
+                "extends": "Error",
+                "constructor": {
+                    "override-signatures": [
+                        "new(message?: string): LinkError",
+                        "(message?: string): LinkError"
+                    ]
+                }
+            },
+            "RuntimeError": {
+                "extends": "Error",
+                "constructor": {
+                    "override-signatures": [
+                        "new(message?: string): RuntimeError",
+                        "(message?: string): RuntimeError"
+                    ]
+                }
             }
         }
     },