New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][docs] downdrage sphinx and fix LaTeX error in R-package tests #2977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I had a feeling this would have to be the answer :/
This PR is facing the same issue #2976 (comment). I think we should extract workaround from @henry0312's PR to make it clean. |
oh nice ok! @henry0312 you can ignore https://github.com/microsoft/LightGBM/pull/2976/files#r404111998, we'll just bundle it into this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with the R changes, merge whenever it builds
I have no idea about |
@StrikerRUS since this is blocking other PRs, I think we should do this:
Then I can work on fixing it today, but other PRs will be unblocked |
As other PRs are not urgent (maintaince or new feature related), I believe they can wait while we are fixing this error. |
I'm ok with that. If they become more urgent, just know I'm ok with that temporary solution. |
This reverts commit 3cdf647.
Just reverted Last year they fixed it in the same day. |
OK, as it was suggested in maillist, I added |
Merging this to unblock all waiting PRs. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Fixed #2974.
While we are waiting new breathe release which will be compatible with sphinx 3, let's downgrade sphinx version to fix our CI.
Refer to breathe-doc/breathe#491.