Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][docs] downdrage sphinx and fix LaTeX error in R-package tests #2977

Merged
merged 4 commits into from Apr 7, 2020

Conversation

StrikerRUS
Copy link
Collaborator

Fixed #2974.

While we are waiting new breathe release which will be compatible with sphinx 3, let's downgrade sphinx version to fix our CI.
Refer to breathe-doc/breathe#491.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I had a feeling this would have to be the answer :/

@jameslamb
Copy link
Collaborator

😱 oh no

image

@StrikerRUS
Copy link
Collaborator Author

This PR is facing the same issue #2976 (comment). I think we should extract workaround from @henry0312's PR to make it clean.

@jameslamb
Copy link
Collaborator

oh nice ok! @henry0312 you can ignore https://github.com/microsoft/LightGBM/pull/2976/files#r404111998, we'll just bundle it into this PR

@StrikerRUS StrikerRUS changed the title [ci][docs] downdrage sphinx [ci][docs] downdrage sphinx and fix LaTeX error in R-package tests Apr 6, 2020
@jameslamb jameslamb self-requested a review April 6, 2020 14:09
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the R changes, merge whenever it builds

@henry0312
Copy link
Contributor

I have no idea about /Library/TeX/texbin/tlmgr: unexpected return value from verify_checksum: -5
https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=5753&view=logs&j=2e42d92c-6989-5c5a-9adb-4d8d43874989&t=7c5d831f-c13d-5c19-c317-c20b1d55f3d3&l=75

@jameslamb
Copy link
Collaborator

@StrikerRUS since this is blocking other PRs, I think we should do this:

if [[ $OS_NAME == "macos" ]]; then
    R CMD check ${PKG_TARBALL} \
        --no-manual \
    || exit -1
else
    R CMD check ${PKG_TARBALL} \
        --as-cran \
    || exit -1
fi

Then I can work on fixing it today, but other PRs will be unblocked

@StrikerRUS
Copy link
Collaborator Author

@jameslamb

since this is blocking other PRs, I think we should do this:

As other PRs are not urgent (maintaince or new feature related), I believe they can wait while we are fixing this error.

@jameslamb
Copy link
Collaborator

@jameslamb

since this is blocking other PRs, I think we should do this:

As other PRs are not urgent (maintaince or new feature related), I believe they can wait while we are fixing this error.

I'm ok with that. If they become more urgent, just know I'm ok with that temporary solution.

This reverts commit 3cdf647.
@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Apr 6, 2020

Just reverted tlmgr-related changes as it is "every year" problem and we have nothing to do with it. Refer to #2976 (comment).

Last year they fixed it in the same day.

@StrikerRUS
Copy link
Collaborator Author

OK, as it was suggested in maillist, I added --verify-repo=none option to install all needed stuff.

@StrikerRUS
Copy link
Collaborator Author

Merging this to unblock all waiting PRs.

@StrikerRUS StrikerRUS merged commit ce08242 into master Apr 7, 2020
@StrikerRUS StrikerRUS deleted the docs branch April 7, 2020 13:24
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] current master fails in docs test
3 participants