Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fixed r-lintr version constraint #2990

Merged
merged 2 commits into from
Apr 13, 2020
Merged

[ci] fixed r-lintr version constraint #2990

merged 2 commits into from
Apr 13, 2020

Conversation

StrikerRUS
Copy link
Collaborator

Fixed #2986.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is WILD how did you know to try this?

Also I see this issue on Mac R builds now 🤒

image

@StrikerRUS
Copy link
Collaborator Author

This is WILD how did you know to try this?

It was the first thing that came to my mind when I saw your words about

I see the first conda install reflected in the logs
but not the second one with libxml2 and r-lintr

@jameslamb
Copy link
Collaborator

This is WILD how did you know to try this?

It was the first thing that came to my mind when I saw your words about

I see the first conda install reflected in the logs
but not the second one with libxml2 and r-lintr

amazing

@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Apr 10, 2020

Also I see this issue on Mac R builds now 🤒

curl: (22) The requested URL returned error: 404 Not Found
Error: Download failed on Cask 'basictex' with message: Download failed: http://mirror.ctan.org/systems/mac/mactex/mactex-basictex-20191011.pkg

@jameslamb
Copy link
Collaborator

Also I see this issue on Mac R builds now 🤒

curl: (22) The requested URL returned error: 404 Not Found

It has to be a transient thing, right? Because the Mac builds on Travis use the exact same code and worked fine

@StrikerRUS
Copy link
Collaborator Author

It has to be a transient thing, right?

I hope so... Or it's something wrong with certificates like in #2977.
Let's wait a little bit a see 🙂

@StrikerRUS
Copy link
Collaborator Author

I guess here is the root cause:
Homebrew/homebrew-cask#80370

May take time for all mirrors around the world to update.

@StrikerRUS
Copy link
Collaborator Author

Let's wait a little bit a see

OK, I think it's time to ask what's going on: Homebrew/homebrew-cask#80370 (comment).

@StrikerRUS
Copy link
Collaborator Author

Hmm, seems that 24h is not enough to update the URL. Guess we should wait till Monday.

@StrikerRUS
Copy link
Collaborator Author

Still no updates for some other mirros (they are changed automatically when I re-run CI job).

# temp fix for basictex
if [[ $AZURE == "true" ]]; then
brew update
fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change only for AZURE? just to save build time?

ugh the Azure Mac builds are such a pain. I had to do another "if Azure" thing on a PR I'm working on:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change only for AZURE? just to save build time?

Yeah! Seems that Travis does it automatically during setup.sh.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do another "if Azure" thing on a PR I'm working on:

Hmmm, it may be dangerous. Refer to #2889. Have you checked that no warnings appeared?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw those exact warnings actually. Thanks for the reminder!

Still just experimenting with things 😬

@StrikerRUS StrikerRUS merged commit be591c8 into master Apr 13, 2020
@jameslamb
Copy link
Collaborator

hey glad that it worked! Thank you!!

@StrikerRUS StrikerRUS deleted the StrikerRUS-patch-1 branch April 13, 2020 21:17
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ci] R linter is broken
2 participants