Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple workbox bundles to allowed packages #583

Merged
merged 2 commits into from Dec 28, 2022
Merged

Add multiple workbox bundles to allowed packages #583

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fa72b2
Add multiple `workbox` bundles to allowed packages
NivaldoFarias Dec 22, 2022
94313ef
chore: add `@types/` packages to allowed list; remove original ones
NivaldoFarias Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/definitions-parser/allowedPackageJsonDependencies.txt
View file
Open in desktop
Expand Up @@ -749,6 +749,19 @@
@types/winston
@types/wonder-commonlib
@types/wonder-frp
@types/workbox-background-sync
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to reference the type declarations used inside the DT customize-cra and workbox-sw packages, all of these @types/ packages need to be included in the allowed packages list. The dependencies inside the mentioned DT packages refer to older, to-be-removed DT workbox-_ packages.

see PR to remove old workbox-_ packages

@types/workbox-broadcast-update
@types/workbox-expiration
@types/workbox-core
@types/workbox-expiration
@types/workbox-navigation-preload
@types/workbox-precaching
@types/workbox-range-requests
@types/workbox-routing
@types/workbox-strategies
@types/workbox-streams
@types/workbox-webpack-plugin
@types/workbox-window
@types/parse5
@uirouter/angularjs
@vue/reactivity
Expand Down Expand Up @@ -1037,7 +1050,6 @@ web-tree-sitter
winston
winston-transport
workbox-build
workbox-webpack-plugin
xmlbuilder
xpath
yup
Expand Down