Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin TypeScript to a version that doesn't cause rollup to hang forever #2923

Merged
merged 4 commits into from Aug 27, 2021

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Aug 27, 2021

CI is hanging on what looks like the npm build step in the modules test: https://dev.azure.com/MSRC-CCF/CCF/_build/results?buildId=31481&view=results

  1. Running without the modules test completes (https://dev.azure.com/MSRC-CCF/CCF/_build/results?buildId=31487&view=results)
  2. The issue can be reproduced locally (make sure to clear your packages-lock.json), rollup hangs during execution. This seems to be caused by (upstream TypeScript bug) Builds hang with typescript 4.4.2 rollup/plugins#983
  3. For now we will pin a slightly older TypeScript.

@achamayou achamayou requested a review from a team as a code owner August 27, 2021 08:37
@achamayou achamayou marked this pull request as draft August 27, 2021 08:37
@ccf-bot
Copy link
Collaborator

ccf-bot commented Aug 27, 2021

isolate_ci_failure@31517 aka 20210827.12 vs main ewma over 20 builds from 30924 to 31481

Click to see table
build_id build_number tpcc_sgx_cft^ tpcc_sgx_cft_mem tpcc_sgx_bft^ tpcc_sgx_bft_mem ls_sgx_cft^ ls_sgx_cft_mem ls_jwt_sgx_cft^ ls_jwt_sgx_cft_mem ls_js_sgx_cft^ ls_js_sgx_cft_mem ls_full_js_sgx_cft^ ls_full_js_sgx_cft_mem ls_js_jwt_sgx_cft^ ls_js_jwt_sgx_cft_mem CHAMP put (/s)^ CHAMP get (/s)^
30924 20210817.2 6443.73 9.13613e+07 1559.08 1.49819e+08 23962.5 1.69124e+07 4464.94 1.56017e+07 2692.62 1.27181e+07 2549.73 1.27181e+07 1775.92 8.2617e+06 1.45723e+06 3.58042e+07
30937 20210818.2 6456.31 9.05749e+07 1576.24 1.55587e+08 24271.5 1.69124e+07 4389.05 1.56017e+07 2700.73 1.27181e+07 2598.01 1.40289e+07 1751.72 8.2617e+06 1.43719e+06 3.45946e+07
30999 20210819.2 6378.54 9.13613e+07 1408.88 1.60567e+08 23878.8 1.69124e+07 4335.24 1.56017e+07 2678.52 1.21939e+07 2589.41 9.83456e+06 1688.35 8.52384e+06 1.46306e+06 3.58669e+07
31027 20210820.2 6699.2 9.10992e+07 1326.54 1.88355e+08 23507.7 1.69124e+07 4261.9 1.56017e+07 2712.05 1.27181e+07 2536.69 1.37667e+07 1813.15 8.2617e+06 1.48158e+06 3.60557e+07
31146 20210823.2 6653.03 9.10992e+07 1556.03 1.55849e+08 24014.8 1.66503e+07 4358.66 1.56017e+07 2722.68 1.00967e+07 2553.12 1.37667e+07 1807.81 8.2617e+06 1.46578e+06 3.59298e+07
31160 20210823.6 5879.02 9.24099e+07 1380.69 1.61092e+08 23947.3 1.66503e+07 4344.26 1.56017e+07 2699.35 1.27181e+07 2529.79 1.4291e+07 1809.55 8.2617e+06 1.39689e+06 3.48299e+07
31178 20210823.11 6370.36 9.26721e+07 1561.11 1.53227e+08 23870.3 1.69124e+07 4429.73 1.56017e+07 2617.65 1.32424e+07 2572.22 1.40289e+07 1797.35 8.2617e+06 1.48083e+06 3.66362e+07
31193 20210823.15 6601.46 9.13613e+07 1483.06 1.50868e+08 24131 1.66503e+07 4383.43 1.53396e+07 2656.96 1.2456e+07 2592.79 1.45532e+07 1801.74 7.99955e+06 1.46337e+06 3.55549e+07
31221 20210823.23 6444.24 9.18856e+07 1653.86 1.45887e+08 24018.3 1.69124e+07 4460.12 1.56017e+07 2649.61 1.21939e+07 2558.63 9.83456e+06 1809.31 8.2617e+06 1.46756e+06 3.58042e+07
31245 20210823.30 6630.89 9.10992e+07 1335.22 1.57422e+08 23995 1.66503e+07 4338.79 1.53396e+07 2667.85 1.00967e+07 2599.95 1.4291e+07 1810.8 8.2617e+06 1.45197e+06 3.55556e+07
31266 20210823.36 6624.45 9.21478e+07 1274.44 1.72626e+08 24076.3 1.66503e+07 4497.26 1.63882e+07 2683.79 1.32424e+07 2532.22 1.37667e+07 1806.87 8.2617e+06 1.46055e+06 3.58669e+07
31276 20210824.2 6691.91 9.24099e+07 1235.1 1.81015e+08 23819.1 1.66503e+07 4512.14 1.56017e+07 2577.22 1.35046e+07 2566.84 1.40289e+07 1811.18 8.2617e+06 1.4902e+06 3.5993e+07
31309 20210825.2 6421.69 9.24099e+07 1484.76 1.57946e+08 24049 1.69124e+07 4435.29 1.53396e+07 2601.1 1.29803e+07 2567.18 9.83456e+06 1812.31 8.2617e+06 1.47105e+06 3.55556e+07
31325 20210825.8 6525.68 9.18856e+07 1508.81 1.61878e+08 24057.7 1.66503e+07 4502.11 1.56017e+07 2659.96 1.32424e+07 2584.19 1.21939e+07 1680.34 7.99955e+06 1.47105e+06 3.59298e+07
31369 20210826.2 6692.32 9.21478e+07 1563.85 1.73937e+08 24027.1 1.69124e+07 4572.54 1.53396e+07 2654.28 1.00967e+07 2579.23 1.48153e+07 1776.76 8.2617e+06 1.49423e+06 3.58669e+07
31386 20210826.9 6510.66 9.26721e+07 1416.79 1.54276e+08 23958.4 1.66503e+07 4563.94 1.53396e+07 2702.6 1.00967e+07 2545.59 1.4291e+07 1809.97 1.00967e+07 1.46422e+06 3.59298e+07
31442 20210826.27 6609.4 9.18856e+07 1429.98 1.65024e+08 24121.7 1.69124e+07 4478.89 1.56017e+07 2687.29 1.19317e+07 2567.16 1.2456e+07 1825.35 8.52384e+06 1.46651e+06 3.65708e+07
31461 20210826.33 6623.34 9.16235e+07 1334.49 1.60043e+08 24072.4 1.69124e+07 4399.38 1.58639e+07 2713.56 1.32424e+07 2538.1 1.40289e+07 1813.02 8.78598e+06 1.4453e+06 3.56794e+07
31480 20210827.2 6422.78 9.13613e+07 1683.46 1.50082e+08 24002.8 1.69124e+07 4485.2 1.58639e+07 2669.38 1.29803e+07 2604.55 1.45532e+07 1816.39 8.52384e+06 1.46035e+06 3.57411e+07
31481 20210827.3 6621.9 9.26721e+07 1559.41 1.60305e+08 24396.1 1.71746e+07 4507.39 1.63882e+07 2695.22 1.2456e+07 2592.04 9.31027e+06 1809.74 8.52384e+06 1.47454e+06 3.57417e+07

images

@achamayou achamayou changed the title Confirm whether the modules test is blocking the build Pin TypeScript to a version that doesn't cause rollup to hang forever Aug 27, 2021
@achamayou achamayou marked this pull request as ready for review August 27, 2021 11:02
@achamayou achamayou merged commit d51b062 into microsoft:main Aug 27, 2021
@eddyashton eddyashton added the 1.x-todo PRs which should be backported to 1.x label Aug 31, 2021
This was referenced Aug 31, 2021
achamayou pushed a commit that referenced this pull request Sep 14, 2021
@achamayou achamayou removed the 1.x-todo PRs which should be backported to 1.x label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants