Pin TypeScript to a version that doesn't cause rollup to hang forever (…

…#2923)
microsoft · Aug 27, 2021 · d51b062 · d51b062
1 parent d3aebe8
commit d51b062
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/tests/js-modules/modules.py b/tests/js-modules/modules.py
@@ -255,8 +255,11 @@ def test_npm_app(network, args):
 
     LOG.info("Building npm app")
     app_dir = os.path.join(PARENT_DIR, "npm-app")
-    subprocess.run(["npm", "install"], cwd=app_dir, check=True)
-    subprocess.run(["npm", "run", "build"], cwd=app_dir, check=True)
+    assert infra.proc.ccall("npm", "install", path=app_dir).returncode == 0
+    assert (
+        infra.proc.ccall("npm", "run", "build", "--verbose", path=app_dir).returncode
+        == 0
+    )
 
     LOG.info("Deploying npm app")
     bundle_dir = os.path.join(app_dir, "dist")

diff --git a/tests/npm-app/package.json b/tests/npm-app/package.json
@@ -24,6 +24,6 @@
     "http-server": "^0.12.3",
     "rollup": "^2.41.0",
     "tslib": "^2.0.1",
-    "typescript": "^4.2.0"
+    "typescript": "4.2.4"
   }
 }