Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to check support for application/x-www-form-urlencoded MediaType #666

Closed
wants to merge 5 commits into from

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Jul 25, 2022

Related to micronaut-projects/micronaut-aws#1414
Related to micronaut-projects/micronaut-azure#363

I am writing some similar tests to see if MediaType.APPLICATION_FORM_URLENCODED is supported. The endpoints that don't have @Body annotations are failing with HttpClientResponseException: Bad Request

@wetted wetted requested review from timyates and sdelamo July 25, 2022 20:19
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these tests should be in the gcp-function-http module not in the gcp-function-http-test module.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wetted wetted requested a review from sdelamo August 1, 2022 18:14
@wetted wetted self-assigned this Oct 18, 2022
@wetted wetted marked this pull request as ready for review November 21, 2022 16:52
@wetted wetted changed the title WIP: tests to check support for application/x-www-form-urlencoded MediaType Tests to check support for application/x-www-form-urlencoded MediaType Nov 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdelamo
Copy link
Contributor

sdelamo commented Dec 20, 2022

We are going to implement the TCK instead in this project: micronaut-projects/micronaut-core#8499

@sdelamo sdelamo closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants