Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: resolve checkstyle error #728

Merged
merged 2 commits into from
Nov 23, 2022
Merged

CI: resolve checkstyle error #728

merged 2 commits into from
Nov 23, 2022

Conversation

wetted
Copy link
Contributor

@wetted wetted commented Nov 21, 2022

#693 added GoogleAuthServiceConfig class without javadoc for public API, resulting in checkstyle errors that fail CI builds.

#666 depends on this PR to build successfully

ping @kgreulich

@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sdelamo sdelamo merged commit 62f1293 into master Nov 23, 2022
@sdelamo sdelamo deleted the resolve_checstyle_error branch November 23, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo approved these changes

@graemerocher graemerocher Awaiting requested review from graemerocher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wetted @sdelamo