Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward early websocket client errors to client future, not the websocket bean #8300

Merged
merged 2 commits into from Nov 23, 2022
Merged

Forward early websocket client errors to client future, not the websocket bean #8300

merged 2 commits into from Nov 23, 2022

Commits on Nov 7, 2022

  1. Forward early websocket client errors to client future, not the webso… 

    …cket bean

When the websocket is closed, but the session has not yet been initialized (and OnOpen not been called), change handleCloseReason to instead emit an error on the publisher that is returned by the `WebSocketClient.connect` method. This means the publisher won't get stuck, and the OnClose method won't be called without a session being available.

Additionally, I refactored `AbstractNettyWebSocketHandler` and the subclasses a bit. The bodyArgument/pongArgument code, and the old callOpenMethod, were only used for the server handler.

Hopefully fixes #7921
    @yawkat
    yawkat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    ee32149 View commit details
    Browse the repository at this point in the history

  2. checkstyle

    @yawkat
    yawkat committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    f1fe309 View commit details
    Browse the repository at this point in the history