Forward early websocket client errors to client future, not the websocket bean #8300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cket bean When the websocket is closed, but the session has not yet been initialized (and OnOpen not been called), change handleCloseReason to instead emit an error on the publisher that is returned by the `WebSocketClient.connect` method. This means the publisher won't get stuck, and the OnClose method won't be called without a session being available. Additionally, I refactored `AbstractNettyWebSocketHandler` and the subclasses a bit. The bodyArgument/pongArgument code, and the old callOpenMethod, were only used for the server handler. Hopefully fixes #7921
|
once this is merged can you deal with merging into 4.0.x since the location of these classes changed there. |
graemerocher
approved these changes
Nov 7, 2022
|
how do i do that, just create a PR that merges 3.8.x into 4.0.x? |
|
That will do |
|
SonarCloud Quality Gate failed. |
|
ping @timyates |
timyates
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the websocket is closed, but the session has not yet been initialized (and OnOpen not been called), change handleCloseReason to instead emit an error on the publisher that is returned by the
WebSocketClient.connectmethod. This means the publisher won't get stuck, and the OnClose method won't be called without a session being available.Additionally, I refactored
AbstractNettyWebSocketHandlerand the subclasses a bit. The bodyArgument/pongArgument code, and the old callOpenMethod, were only used for the server handler.FYI: there is a merge conflict with 4.0.x, where I did a similar change in
channelActive. The code from this PR is correct for 4.0.x as well.Hopefully fixes #7921