Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly proceed in filter processing when request is replaced #7174

Merged
merged 7 commits into from Apr 5, 2022
Merged

Properly proceed in filter processing when request is replaced #7174

merged 7 commits into from Apr 5, 2022

Commits on Apr 1, 2022

  1. Properly proceed in filter processing when request is replaced 

    When a filter calls chain.proceed with a new request, that request should be used for further processing.
Replacing the request is still not fully working even with this change, so #5491 is not fully fixed. RoutingInBoundHandler still does not consider the new request, because most of the request processing happens before the filter is applied. In the test case of this patch, this manifests as the response text still being "initial" even though the request has been replaced.
    @yawkat
    yawkat committed Apr 1, 2022
    Copy the full SHA
    cb94524 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. use type

    @sdelamo
    sdelamo committed Apr 5, 2022
    Copy the full SHA
    5217a0c View commit details
    Browse the repository at this point in the history

  2. remove implicit return keyword

    @sdelamo
    sdelamo committed Apr 5, 2022
    Copy the full SHA
    97ec2f7 View commit details
    Browse the repository at this point in the history

  3. use EmbeddedServer server = ApplicationContext.run(EmbeddedServer,

    @sdelamo
    sdelamo committed Apr 5, 2022
    Copy the full SHA
    b613fa9 View commit details
    Browse the repository at this point in the history

  4. remove extra blank line

    @sdelamo
    sdelamo committed Apr 5, 2022
    Copy the full SHA
    a4da25d View commit details
    Browse the repository at this point in the history

  5. test: use @shared

    @sdelamo
    sdelamo committed Apr 5, 2022
    Copy the full SHA
    27e8cfd View commit details
    Browse the repository at this point in the history

  6. extract test and annotate with @PendingFeature

    @sdelamo
    sdelamo committed Apr 5, 2022
    Copy the full SHA
    3e72e9f View commit details
    Browse the repository at this point in the history