New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly proceed in filter processing when request is replaced #7174
Conversation
When a filter calls chain.proceed with a new request, that request should be used for further processing. Replacing the request is still not fully working even with this change, so #5491 is not fully fixed. RoutingInBoundHandler still does not consider the new request, because most of the request processing happens before the filter is applied. In the test case of this patch, this manifests as the response text still being "initial" even though the request has been replaced.
I assume that in the test scenario what should happen is that the application responds filter2. I have created such a test and annotated with |
should we point this to 3.4.x or 3.5.x? |
This is a bug, it should be 3.4.x |
Kudos, SonarCloud Quality Gate passed! |
When a filter calls chain.proceed with a new request, that request should be used for further processing.
Replacing the request is still not fully working even with this change, so #5491 is not fully fixed. RoutingInBoundHandler still does not consider the new request, because most of the request processing happens before the filter is applied. In the test case of this patch, this manifests as the response text still being "initial" even though the request has been replaced.