Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log ExecutorServiceMetrics.bindTo() failure #2443

Merged
merged 3 commits into from Feb 11, 2021
Merged

Log ExecutorServiceMetrics.bindTo() failure #2443

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
058b9d8
Log ExecutorServiceMetrics.bindTo() failure
izeye Feb 10, 2021
ade0ef9
Fix a wrong class reference for a logger
izeye Feb 11, 2021
9c7f6e4
Use conventional order for modifiers
izeye Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...r-core/src/main/java/io/micrometer/core/instrument/binder/jvm/ExecutorServiceMetrics.java
View file
Open in desktop
Expand Up @@ -25,6 +25,8 @@
import io.micrometer.core.lang.NonNullApi;
import io.micrometer.core.lang.NonNullFields;
import io.micrometer.core.lang.Nullable;
import io.micrometer.core.util.internal.logging.InternalLogger;
import io.micrometer.core.util.internal.logging.InternalLoggerFactory;

import java.lang.reflect.Field;
import java.util.concurrent.*;
Expand All @@ -43,6 +45,9 @@
@NonNullApi
@NonNullFields
public class ExecutorServiceMetrics implements MeterBinder {

private static final InternalLogger log = InternalLoggerFactory.getInstance(ExecutorServiceMetrics.class);

static final String DEFAULT_EXECUTOR_METRIC_PREFIX = "";
@Nullable
private final ExecutorService executorService;
Expand Down Expand Up @@ -277,6 +282,8 @@ public void bindTo(MeterRegistry registry) {
monitor(registry, unwrapThreadPoolExecutor(executorService, executorService.getClass().getSuperclass()));
} else if (executorService instanceof ForkJoinPool) {
monitor(registry, (ForkJoinPool) executorService);
} else {
log.warn("Failed to bind as {} is unsupported.", className);
}
}

Expand Down