Log ExecutorServiceMetrics.bindTo() failure #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checketts
approved these changes
Feb 10, 2021
jonatan-ivanov
requested changes
Feb 11, 2021
...eter-core/src/main/java/io/micrometer/core/instrument/binder/jvm/ExecutorServiceMetrics.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
jonatan-ivanov
requested changes
Feb 11, 2021
...eter-core/src/main/java/io/micrometer/core/instrument/binder/jvm/ExecutorServiceMetrics.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
shakuzen
added a commit
that referenced
this pull request
Feb 16, 2021
It can be unclear why metrics are missing when passing a wrapped type, as the API seems to indicate any `Executor` or `ExecutorService` can be monitored. This makes explicit the types we can monitor and notes unwrapping should be done by the user, since we cannot know wrapper types from external code. See gh-2443 and gh-2426
|
Thanks. I've added a note to the class JavaDoc providing more explicit guidance to hopefully avoid the issue for some users. 3062418 |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to log
ExecutorServiceMetrics.bindTo()failure.See gh-2426